From: Andreas Larsson <andreas@gaisler.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"David S. Miller" <davem@davemloft.net>
Cc: Rob Herring <robh@kernel.org>, Sam Ravnborg <sam@ravnborg.org>,
sparclinux@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH 0/6] sbus: Convert to platform remove callback returning void
Date: Fri, 8 Mar 2024 21:12:27 +0100 [thread overview]
Message-ID: <5d6d6ab9-58a8-4bf7-abed-b620b28468c7@gaisler.com> (raw)
In-Reply-To: <cover.1709591118.git.u.kleine-koenig@pengutronix.de>
On 2024-03-04 23:30, Uwe Kleine-König wrote:
> Hello,
>
> this series converts all platform drivers below drivers/sbus/platform to
> struct platform_driver::remove_new(). See commit 5c5a7680e67b
> ("platform: Provide a remove callback that returns no value") for an
> extended explanation and the eventual goal.
>
> The first commit is a build fix. The remaining patches implement that
> actual conversion. All conversations are trivial, because their
> .remove() callbacks returned zero unconditionally.
>
> Apart from patch #2 building on top of #1, there are no
> interdependencies between these patches, so they could be picked up
> individually. But I'd hope that they get picked up all together by
> Andreas (or Dave?).
>
> Best regards
> Uwe
>
> Uwe Kleine-König (6):
> sbus: Add prototype for bbc_envctrl_init and bbc_envctrl_cleanup to
> header
> sbus: bbc_i2c: Convert to platform remove callback returning void
> sbus: display7seg: Convert to platform remove callback returning void
> sbus: envctrl: Convert to platform remove callback returning void
> sbus: flash: Convert to platform remove callback returning void
> sbus: uctrl: Convert to platform remove callback returning void
>
> drivers/sbus/char/bbc_i2c.c | 9 ++-------
> drivers/sbus/char/bbc_i2c.h | 3 +++
> drivers/sbus/char/display7seg.c | 6 ++----
> drivers/sbus/char/envctrl.c | 6 ++----
> drivers/sbus/char/flash.c | 6 ++----
> drivers/sbus/char/uctrl.c | 5 ++---
> 6 files changed, 13 insertions(+), 22 deletions(-)
>
> base-commit: 67908bf6954b7635d33760ff6dfc189fc26ccc89
For the whole series,
Reviewed-by: Andreas Larsson <andreas@gaisler.com>
Picking this up to my for-next.
Thanks,
Andreas
prev parent reply other threads:[~2024-03-08 20:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 22:30 [PATCH 0/6] sbus: Convert to platform remove callback returning void Uwe Kleine-König
2024-03-04 22:30 ` [PATCH 1/6] sbus: Add prototype for bbc_envctrl_init and bbc_envctrl_cleanup to header Uwe Kleine-König
2024-03-04 22:30 ` [PATCH 2/6] sbus: bbc_i2c: Convert to platform remove callback returning void Uwe Kleine-König
2024-03-04 22:30 ` [PATCH 3/6] sbus: display7seg: " Uwe Kleine-König
2024-03-04 22:30 ` [PATCH 4/6] sbus: envctrl: " Uwe Kleine-König
2024-03-04 22:30 ` [PATCH 5/6] sbus: flash: " Uwe Kleine-König
2024-03-04 22:30 ` [PATCH 6/6] sbus: uctrl: " Uwe Kleine-König
2024-03-08 20:12 ` Andreas Larsson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d6d6ab9-58a8-4bf7-abed-b620b28468c7@gaisler.com \
--to=andreas@gaisler.com \
--cc=davem@davemloft.net \
--cc=kernel@pengutronix.de \
--cc=robh@kernel.org \
--cc=sam@ravnborg.org \
--cc=sparclinux@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).