From: Sam Ravnborg <sam@ravnborg.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "Maciej W. Rozycki" <macro@orcam.me.uk>,
Miquel Raynal <miquel.raynal@bootlin.com>,
sparclinux@vger.kernel.org, linux-parport@lists.infradead.org,
"David S . Miller" <davem@davemloft.net>,
Andreas Larsson <andreas@gaisler.com>,
Randy Dunlap <rdunlap@infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/6] sparc32: Do not select GENERIC_ISA_DMA
Date: Sat, 24 Feb 2024 18:14:43 +0100 [thread overview]
Message-ID: <20240224171443.GA3312322@ravnborg.org> (raw)
In-Reply-To: <73d9824f-898a-48ea-b3a8-ea420e3be007@app.fastmail.com>
Hi Arnd,
On Sat, Feb 24, 2024 at 12:24:01PM +0100, Arnd Bergmann wrote:
> On Sat, Feb 24, 2024, at 06:29, Maciej W. Rozycki wrote:
> > On Sat, 24 Feb 2024, Maciej W. Rozycki wrote:
> >
> > The GENERIC_ISA_DMA option itself was added to arch/sparc/config.in with
> > 2.5.31 as:
> >
> > define_bool CONFIG_GENERIC_ISA_DMA y
> >
> > despite of:
> >
> > define_bool CONFIG_ISA n
>
> I think I've seen any combination of CONFIG_ISA (the 62/98 pin slots), CONFIG_GENERIC_ISA_DMA (the request_dma() interface) and
> CONFIG_ISA_DMA_API (the set_dma_addr()/enable_dma() type interface),
> but I agree that sparc should have none of the three as both
> floppy and parport use some other interface.
>
> > for a reason not clear to me (BLK_DEV_FD? -- but on SPARC that uses some
> > hacks to work in the absence of ISA DMA anyway).
> >
> > Am I missing anything here?
>
> I think it was part of the ISA DMA lookalike that got removed
> in 334ae614772b ("sparc: Kill SBUS DVMA layer.") and should
> have been changed back then.
Hmm, that may well be the case.
I checked and sparc32 do not set any ISA symbols anymore
so we should be OK now.
I decided to just drop the Fixes: tag to not confuse anyone.
Sam
next prev parent reply other threads:[~2024-02-24 17:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 19:36 [PATCH 0/6] sparc32: build fixes for all{yes,mod}config builds Sam Ravnborg via B4 Relay
2024-02-23 19:36 ` [PATCH 1/6] sparc32: Use generic cmpdi2/ucmpdi2 variants Sam Ravnborg via B4 Relay
2024-02-24 0:27 ` Randy Dunlap
2024-02-24 2:54 ` Maciej W. Rozycki
2024-02-23 19:36 ` [PATCH 2/6] sparc32: Fix build with trapbase Sam Ravnborg via B4 Relay
2024-02-24 0:29 ` Randy Dunlap
2024-02-23 19:36 ` [PATCH 3/6] mtd: maps: sun_uflash: Declare uflash_devinit static Sam Ravnborg via B4 Relay
2024-02-24 0:30 ` Randy Dunlap
2024-02-23 19:36 ` [PATCH 4/6] usb: host: uhci-grlib.c: Fix build, add platform_device Sam Ravnborg via B4 Relay
2024-02-24 0:31 ` Randy Dunlap
2024-02-23 19:36 ` [PATCH 5/6] sparc32: Do not select GENERIC_ISA_DMA Sam Ravnborg via B4 Relay
2024-02-24 0:32 ` Randy Dunlap
2024-02-24 2:55 ` Maciej W. Rozycki
2024-02-24 5:29 ` Maciej W. Rozycki
2024-02-24 7:59 ` Sam Ravnborg
2024-02-24 11:24 ` Arnd Bergmann
2024-02-24 17:14 ` Sam Ravnborg [this message]
2024-02-23 19:36 ` [PATCH 6/6] sparc32: Fix parport build with sparc32 Sam Ravnborg via B4 Relay
2024-02-24 0:34 ` Randy Dunlap
2024-02-24 3:02 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240224171443.GA3312322@ravnborg.org \
--to=sam@ravnborg.org \
--cc=andreas@gaisler.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parport@lists.infradead.org \
--cc=macro@orcam.me.uk \
--cc=miquel.raynal@bootlin.com \
--cc=rdunlap@infradead.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).