From: John Levon <levon@movementarian.org>
Subject: [PATCH 05/18] sparse: correctly handle "-D foo" and "-U foo". The former is from sparse upstream, but they didn't fix the latter for some reason.
Date: Thu, 22 Nov 2018 12:08:06 +0000 [thread overview]
Message-ID: <E1gQCRW-00067i-Q6@movementarian.org> (raw)
Signed-off-by: John Levon <levon@movementarian.org>
---
lib.c | 16 +++++++++++-----
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/lib.c b/lib.c
index f20e0885..d7cd8cbc 100644
--- a/lib.c
+++ b/lib.c
@@ -325,15 +325,19 @@ static char **handle_switch_D(char *arg, char **next)
const char *name = arg + 1;
const char *value = "1";
- if (!*name || isspace((unsigned char)*name))
- die("argument to `-D' is missing");
+ if (!*name) {
+ arg = *++next;
+ if (!arg)
+ die("argument to `-D' is missing");
+ name = arg;
+ }
- for (;;) {
+ for (;;arg++) {
char c;
- c = *++arg;
+ c = *arg;
if (!c)
break;
- if (isspace((unsigned char)c) || c == '=') {
+ if (c == '=') {
*arg = '\0';
value = arg + 1;
break;
@@ -685,6 +689,8 @@ static void handle_switch_v_finalize(void)
static char **handle_switch_U(char *arg, char **next)
{
const char *name = arg + 1;
+ if (*name == '\0')
+ name = *++next;
add_pre_buffer ("#undef %s\n", name);
return next;
}
--
2.14.1
next reply other threads:[~2018-11-24 1:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-22 12:08 John Levon [this message]
2018-11-25 21:29 ` [PATCH 05/18] sparse: correctly handle "-D foo" and "-U foo". The former is from sparse upstream, but they didn't fix the latter for some reason Luc Van Oostenryck
2018-11-25 23:29 ` John Levon
2018-11-26 0:27 ` Luc Van Oostenryck
2018-11-26 7:49 ` Dan Carpenter
2018-11-29 10:03 ` Sync smatch with sparse? Luc Van Oostenryck
2018-11-29 10:09 ` John Levon
2018-11-26 8:44 ` [PATCH 05/18] sparse: correctly handle "-D foo" and "-U foo". The former is from sparse upstream, but they didn't fix the latter for some reason John Levon
2018-11-26 9:18 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1gQCRW-00067i-Q6@movementarian.org \
--to=levon@movementarian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).