From: Dan Carpenter <dan.carpenter@linaro.org>
To: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Cc: error27@gmail.com, smatch@vger.kernel.org,
harshit.m.mogalapalli@gmail.com
Subject: Re: [PATCH v2] check_unwind: Add request/release_firmware to the function table
Date: Wed, 1 Nov 2023 10:36:00 +0300 [thread overview]
Message-ID: <6d3c0042-9e2d-45d8-9a2c-88d4b1d82f57@kadam.mountain> (raw)
In-Reply-To: <20231031182816.530309-1-harshit.m.mogalapalli@oracle.com>
On Tue, Oct 31, 2023 at 11:28:16AM -0700, Harshit Mogalapalli wrote:
> Add request and release firmware to catch bugs where there is an
> imbalance between release and request firmware.
>
> request_firmware(const struct firmware **firmware_p, const char *name,
> struct device *device)
>
> release frees(firmware) so we should pass '0' to the table entry in the
> ALLOC.
>
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
> ---
> v1-->v2: Fix the return range for success path.
>
Awesome. Thanks! Applied.
regards,
dan carpenter
prev parent reply other threads:[~2023-11-01 7:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-31 18:28 [PATCH v2] check_unwind: Add request/release_firmware to the function table Harshit Mogalapalli
2023-11-01 7:36 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d3c0042-9e2d-45d8-9a2c-88d4b1d82f57@kadam.mountain \
--to=dan.carpenter@linaro.org \
--cc=error27@gmail.com \
--cc=harshit.m.mogalapalli@gmail.com \
--cc=harshit.m.mogalapalli@oracle.com \
--cc=smatch@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).