From: Markus Elfring <Markus.Elfring@web.de>
To: Dan Carpenter <dan.carpenter@linaro.org>,
kernel-janitors@vger.kernel.org, netdev@vger.kernel.org,
intel-wired-lan@lists.osuosl.org, smatch@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
Alexander Lobakin <aleksander.lobakin@intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
David Laight <David.Laight@aculab.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Jiri Pirko <jiri@resnulli.us>,
Jonathan Cameron <jic23@kernel.org>,
Julia Lawall <julia.lawall@inria.fr>,
Kees Cook <keescook@chromium.org>,
Lukasz Czapnik <lukasz.czapnik@intel.com>,
Paolo Abeni <pabeni@redhat.com>,
Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>
Subject: Re: [v2] ice: Fix freeing uninitialized pointers
Date: Sun, 24 Mar 2024 14:22:31 +0100 [thread overview]
Message-ID: <4366d46d-0edc-4e45-8695-9fbaae571049@web.de> (raw)
In-Reply-To: <f292facc-8a22-42e1-9a41-5ec8bd665cb7@moroto.mountain>
>>> Automatically cleaned up pointers need to be initialized before exiting
>>> their scope. In this case, they need to be initialized to NULL before
>>> any return statement.
>>
>> * May we expect that compilers should report that affected variables
>> were only declared here instead of appropriately defined
>> (despite of attempts for scope-based resource management)?
>>
>
> We disabled GCC's check for uninitialized variables a long time ago
> because it had too many false positives.
Can further case distinctions (and compilation parameters) become more helpful
according to the discussed handling of the attribute “__cleanup” (or “__free”)?
>> * Did you extend detection support in the source code analysis tool “Smatch”
>> for a questionable implementation detail?
>
> Yes. Smatch detects this as an uninitialized variable.
Does the corresponding warning indicate requirements for scope-based resource management?
Regards,
Markus
prev parent reply other threads:[~2024-03-24 13:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0efe132b-b343-4438-bb00-5a4b82722ed3@moroto.mountain>
2024-03-23 16:56 ` [PATCH v2 net] ice: Fix freeing uninitialized pointers Markus Elfring
2024-03-24 10:43 ` Dan Carpenter
2024-03-24 13:22 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4366d46d-0edc-4e45-8695-9fbaae571049@web.de \
--to=markus.elfring@web.de \
--cc=David.Laight@aculab.com \
--cc=aleksander.lobakin@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=dan.carpenter@linaro.org \
--cc=dan.j.williams@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=himasekharx.reddy.pucha@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=jic23@kernel.org \
--cc=jiri@resnulli.us \
--cc=julia.lawall@inria.fr \
--cc=keescook@chromium.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukasz.czapnik@intel.com \
--cc=maciej.fijalkowski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=smatch@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).