From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: smatch@vger.kernel.org
Subject: Re: [RFC PATCH] check_freeing_devm: Also track erroneous usage of kfree when the pointer has been re-assigned
Date: Thu, 26 May 2022 16:22:13 +0200 [thread overview]
Message-ID: <3f1bb327-1af8-232d-7f85-b908c72c89d9@wanadoo.fr> (raw)
In-Reply-To: <20220526134923.GG2168@kadam>
Le 26/05/2022 à 15:49, Dan Carpenter a écrit :
> On Thu, May 26, 2022 at 03:37:58PM +0200, Christophe JAILLET wrote:
>> Le 26/05/2022 à 14:00, Dan Carpenter a écrit :
>>> On Thu, May 26, 2022 at 01:40:51PM +0200, Marion & Christophe JAILLET wrote:
>>>> Le 26/05/2022 à 13:07, Dan Carpenter a écrit :
>>>>> On Thu, May 26, 2022 at 12:30:05PM +0200, Christophe JAILLET wrote:
>>>>>> Le 26/05/2022 à 11:51, Dan Carpenter a écrit :
>>>>>>>> All I know is that it seams to work for me, even if it has not detected any
>>>>>>>> issue yet :) (compiling takes SO MUCH time on my machine)
>>>>>>> Yeah. :/ How big is your smatch_db.sqlite file?
>>>>>> I don't use any up-to-now.
>>>>> Basically all my changes are targetted at making the smatch_db.sqlite
>>>>> file smaller so they won't help you. Are you at least doing a parallel
>>>>> build? The smatch_scripts/test_kernel.sh script does a make -j${NR_CPU}.
>>>> Yep.
>>>>
>>>> I've also tweaked smatch_scripts/kchecker which doesn't have any -j, IIUC.
>>> Normally, I only use kchecker on one file... The problem with doing
>>> parallel builds is that you have to print the warnings to a file instead
>>> of to stdout.
>> smatch.txt:
>>
>> You can also build a directory like this:
>>
>> ~/progs/smatch/devel/smatch_scripts/kchecker drivers/whatever/
>>
>> and up no now, it is mostly the wayIi use it, :)
>>
> I guess -j has no downside if you're building a single file.
>
> The only problem is that if you're building a directory and sending
> everything to stdout then the lines can get smooshed together. Is it
> better to just let them smoosh or build the whole directory and then
> find -name \*.c.smatch -exec cat \{\} \;?
Not sure to follow you.
I've not seen any problem yet with using:
../git_smatch/smatch_scripts/kchecker drivers/net/ > results.txt
CJ
>
> regards,
> dan carpenter
>
prev parent reply other threads:[~2022-05-26 14:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-26 7:15 [RFC PATCH] check_freeing_devm: Also track erroneous usage of kfree when the pointer has been re-assigned Christophe JAILLET
2022-05-26 9:51 ` Dan Carpenter
2022-05-26 10:30 ` Christophe JAILLET
2022-05-26 11:07 ` Dan Carpenter
2022-05-26 11:40 ` Marion & Christophe JAILLET
2022-05-26 12:00 ` Dan Carpenter
2022-05-26 13:37 ` Christophe JAILLET
2022-05-26 13:49 ` Dan Carpenter
2022-05-26 14:22 ` Christophe JAILLET [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f1bb327-1af8-232d-7f85-b908c72c89d9@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=dan.carpenter@oracle.com \
--cc=smatch@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).