From: Harshvardhan Jha <harshvardhan.jha@oracle.com>
To: smatch@vger.kernel.org
Cc: dan.carpenter@oracle.com, Harshvardhan Jha <harshvardhan.jha@oracle.com>
Subject: [PATCH] check_do_while_loop_limit: implements checker for do_while loops
Date: Mon, 26 Jul 2021 19:24:12 +0530 [thread overview]
Message-ID: <20210726135412.8209-1-harshvardhan.jha@oracle.com> (raw)
do{} while(n--) loops end at n=-1 but programmers sometimes assume that
they end at n=0. This checker sends a warning in these scenarios.
Signed-off-by: Harshvardhan Jha <harshvardhan.jha@oracle.com>
---
check_do_while_loop_limit.c | 67 +++++++++++++++++++++++++++++++++++++
check_list.h | 1 +
2 files changed, 68 insertions(+)
create mode 100644 check_do_while_loop_limit.c
diff --git a/check_do_while_loop_limit.c b/check_do_while_loop_limit.c
new file mode 100644
index 00000000..cc04dfa5
--- /dev/null
+++ b/check_do_while_loop_limit.c
@@ -0,0 +1,67 @@
+/*
+ * Copyright (C) 2021 Oracle.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; either version 2
+ * of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, see http://www.gnu.org/copyleft/gpl.txt
+ */
+
+#include "smatch.h"
+#include "smatch_slist.h"
+#include "smatch_extra.h"
+
+static int my_id;
+
+STATE(post_minus);
+
+static bool is_post_minus(struct expression *expr)
+{
+ expr = strip_expr(expr);
+ if (!expr)
+ return false;
+ if (expr->type != EXPR_POSTOP)
+ return false;
+ if (expr->op != SPECIAL_DECREMENT)
+ return false;
+ return true;
+}
+
+static void match_post_loop(struct expression *expr)
+{
+ struct statement *stmt;
+
+ expr = strip_expr(expr);
+ stmt = expr_get_parent_stmt(expr);
+
+ if (!stmt)
+ return;
+ if (stmt->type != STMT_ITERATOR)
+ return;
+ if (!is_post_minus(stmt->iterator_post_condition))
+ return;
+ if (is_post_minus(stmt->iterator_post_condition))
+ set_state_expr(my_id, stmt->iterator_post_condition->left, &post_minus);
+}
+
+static void match_condition(struct expression *expr)
+{
+ if (get_state_expr(my_id, expr) != &post_minus)
+ return;
+ sm_warning("do while ends on '%s == -1'", expr_to_str(expr));
+}
+
+void check_do_while_loop_limit(int id)
+{
+ my_id = id;
+ add_hook(&match_post_loop, CONDITION_HOOK);
+ add_hook(&match_condition, CONDITION_HOOK);
+}
diff --git a/check_list.h b/check_list.h
index a57715ea..4d18a173 100644
--- a/check_list.h
+++ b/check_list.h
@@ -171,6 +171,7 @@ CK(check_syscall_arg_type)
CK(check_trinity_generator)
CK(register_param_bits_set)
CK(register_param_bits_clear)
+CK(check_do_while_loop_limit)
/* <- your test goes here */
/* CK(register_template) */
--
2.32.0
next reply other threads:[~2021-07-26 13:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-26 13:54 Harshvardhan Jha [this message]
2021-07-27 9:39 ` [PATCH] check_do_while_loop_limit: implements checker for do_while loops Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2021-07-26 13:43 Harshvardhan Jha
2021-07-26 13:50 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210726135412.8209-1-harshvardhan.jha@oracle.com \
--to=harshvardhan.jha@oracle.com \
--cc=dan.carpenter@oracle.com \
--cc=smatch@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).