From: Harshvardhan Jha <harshvardhan.jha@oracle.com>
To: smatch@vger.kernel.org
Cc: dan.carpenter@oracle.com, Harshvardhan Jha <harshvardhan.jha@oracle.com>
Subject: [PATCH] power_of_two: Track variables which are powers of two
Date: Wed, 21 Jul 2021 01:17:44 +0530 [thread overview]
Message-ID: <20210720194744.168200-1-harshvardhan.jha@oracle.com> (raw)
smatch_power_of_two tracks variables which are powers of two and also
handles exceptions such as sign extensions.
Signed-off-by: Harshvardhan Jha <harshvardhan.jha@oracle.com>
---
Makefile | 1 +
check_list.h | 1 +
smatch.h | 2 +
smatch_power_of_two.c | 167 ++++++++++++++++++++++++++++++++++++++++++
4 files changed, 171 insertions(+)
create mode 100644 smatch_power_of_two.c
diff --git a/Makefile b/Makefile
index 8855c974..9a677990 100644
--- a/Makefile
+++ b/Makefile
@@ -303,6 +303,7 @@ SMATCH_OBJS += smatch_parse_call_math.o
SMATCH_OBJS += smatch_parsed_conditions.o
SMATCH_OBJS += smatch_passes_array_size.o
SMATCH_OBJS += smatch_points_to_user_data.o
+SMATCH_OBJS += smatch_power_of_two.o
SMATCH_OBJS += smatch_project.o
SMATCH_OBJS += smatch_ranges.o
SMATCH_OBJS += smatch_real_absolute.o
diff --git a/check_list.h b/check_list.h
index fd205269..b555557b 100644
--- a/check_list.h
+++ b/check_list.h
@@ -57,6 +57,7 @@ CK(register_integer_overflow_links)
CK(register_real_absolute)
CK(register_imaginary_absolute)
CK(register_bits)
+CK(register_power_of_two)
CK(register_fn_arg_link)
CK(register_parameter_names)
CK(register_return_to_param)
diff --git a/smatch.h b/smatch.h
index 025ad1a8..35a6be7a 100644
--- a/smatch.h
+++ b/smatch.h
@@ -848,6 +848,8 @@ enum info_type {
FRESH_ALLOC = 1044,
ALLOCATOR = 1045,
FUNC_TIME = 1047,
+ POWER_OF_TWO = 1048,
+ POWER_OF_TWO_SET = 1049,
/* put random temporary stuff in the 7000-7999 range for testing */
USER_DATA = 8017,
diff --git a/smatch_power_of_two.c b/smatch_power_of_two.c
new file mode 100644
index 00000000..5ddcfc06
--- /dev/null
+++ b/smatch_power_of_two.c
@@ -0,0 +1,167 @@
+/*
+ * Copyright (C) 2021
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; either version 2
+ * of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, see http://www.gnu.org/copyleft/gpl.txt
+ */
+
+#include "smatch.h"
+#include "smatch_extra.h"
+#include "smatch_slist.h"
+
+static int my_id;
+
+STATE(power_of_two);
+
+bool is_power_of_two(struct expression *expr)
+{
+ sval_t sval;
+
+ expr = strip_expr(expr);
+
+ if (expr->type == EXPR_BINOP &&
+ expr->op == SPECIAL_LEFTSHIFT &&
+ is_power_of_two(expr->left))
+ return true;
+
+ if (get_implied_value(expr, &sval)) {
+ if (!(sval.uvalue & (sval.uvalue - 1)))
+ return true;
+ return false;
+ }
+
+ if (get_state_expr(my_id, expr) == &power_of_two)
+ return true;
+
+ return false;
+}
+
+static bool is_sign_expansion(struct expression *expr)
+{
+ struct range_list *rl;
+ struct symbol *type_left;
+ struct symbol *type_right;
+
+ type_left = get_type(expr->left);
+ type_right = get_type(expr->right);
+ if (!type_left || !type_right)
+ return true;
+ if (type_bits(type_left) <= type_bits(type_right))
+ return false;
+
+ get_absolute_rl(expr->right, &rl);
+ if (sval_is_negative(rl_min(rl)))
+ return true;
+
+ return false;
+}
+
+static void match_assign(struct expression *expr)
+{
+ if (expr->op != '=')
+ return;
+
+ if (is_sign_expansion(expr))
+ return;
+
+ if (is_power_of_two(expr->right))
+ set_state_expr(my_id, expr->left, &power_of_two);
+}
+
+static bool is_minus_mask(struct expression *left, struct expression *right)
+{
+ if (right->type != EXPR_BINOP ||
+ right->op != '-')
+ return false;
+
+ if (right->right->value != 1)
+ return false;
+
+ if (expr_equiv(left, right->left))
+ return true;
+
+ return false;
+}
+
+static void match_condition(struct expression *expr)
+{
+ expr = strip_expr(expr);
+ if (expr->type != EXPR_BINOP ||
+ expr->op != '&')
+ return;
+
+ if (is_minus_mask(strip_expr(expr->left), strip_expr(expr->right))) {
+ set_true_false_states_expr(my_id, expr->left, NULL, &power_of_two);
+ return;
+ }
+
+ if (is_minus_mask(strip_expr(expr->right), strip_expr(expr->left))) {
+ set_true_false_states_expr(my_id, expr->right, NULL, &power_of_two);
+ return;
+ }
+}
+
+static void caller_info_callback(struct expression *call, int param, char *printed_name, struct sm_state *sm)
+{
+ if (sm->state != &power_of_two)
+ return;
+
+ sql_insert_caller_info(call, POWER_OF_TWO, param, printed_name, "");
+}
+
+static void set_power_of_two(const char *name, struct symbol *sym, char *value)
+{
+ set_state(my_id, name, sym, &power_of_two);
+}
+
+static void return_info_callback(int return_id, char *return_ranges,
+ struct expression *returned_expr,
+ int param,
+ const char *printed_name,
+ struct sm_state *sm)
+{
+ struct smatch_state *estate;
+ sval_t sval;
+
+ if (param != -1 && !param_was_set_var_sym(sm->name, sm->sym))
+ return;
+
+ estate = get_state(SMATCH_EXTRA, sm->name, sm->sym);
+ if (estate_get_single_value(estate, &sval))
+ return;
+
+ sql_insert_return_states(return_id, return_ranges, POWER_OF_TWO_SET, param, printed_name, "");
+}
+
+static void returns_power_of_two_set(struct expression *expr, int param, char *key, char *value)
+{
+ char *name;
+ struct symbol *sym;
+
+ name = get_name_sym_from_key(expr, param, key, &sym);
+ if (!name)
+ return;
+ set_state(my_id, name, sym, &power_of_two);
+}
+
+void register_power_of_two(int id)
+{
+ my_id = id;
+
+ add_hook(&match_assign, ASSIGNMENT_HOOK);
+ add_hook(&match_condition, CONDITION_HOOK);
+ add_caller_info_callback(my_id, caller_info_callback);
+ select_caller_name_sym(set_power_of_two, POWER_OF_TWO);
+ add_return_info_callback(my_id, return_info_callback);
+ select_return_states_hook(POWER_OF_TWO_SET, &returns_power_of_two_set);
+}
--
2.32.0
reply other threads:[~2021-07-20 19:07 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210720194744.168200-1-harshvardhan.jha@oracle.com \
--to=harshvardhan.jha@oracle.com \
--cc=dan.carpenter@oracle.com \
--cc=smatch@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).