From: Dan Carpenter <dan.carpenter@oracle.com>
To: John Levon <levon@movementarian.org>
Cc: smatch@vger.kernel.org
Subject: Re: Odd smatch issue?
Date: Mon, 14 Jan 2019 17:51:46 +0300 [thread overview]
Message-ID: <20190114145146.GB4482@kadam> (raw)
In-Reply-To: <20190114144736.GA14913@movementarian.org>
On Mon, Jan 14, 2019 at 02:47:36PM +0000, John Levon wrote:
> On Mon, Jan 14, 2019 at 05:38:00PM +0300, Dan Carpenter wrote:
>
> > Try this patch?
>
> With both applied, smatch now catches the bad code, thanks!
>
> Time to run it across everything...
Very lightly tested, btw. Especially patch 2 might have subtle side
effects. Probably good ones. Or maybe no side effects...
regards,
dan carpenter
prev parent reply other threads:[~2019-01-14 14:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 12:32 Odd smatch issue? John Levon
2019-01-14 10:18 ` Dan Carpenter
2019-01-14 12:42 ` John Levon
2019-01-14 14:38 ` Dan Carpenter
2019-01-14 14:47 ` John Levon
2019-01-14 14:51 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190114145146.GB4482@kadam \
--to=dan.carpenter@oracle.com \
--cc=levon@movementarian.org \
--cc=smatch@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).