From: Dan Carpenter <dan.carpenter@oracle.com>
To: Rasmus Villemoes <rv@rasmusvillemoes.dk>
Cc: smatch@vger.kernel.org
Subject: Re: [PATCH 2/3] smatch_type.c: comparison expressions always have type int
Date: Tue, 31 Oct 2017 15:14:44 +0300 [thread overview]
Message-ID: <20171031121444.outrqs2no7z35dyr@mwanda> (raw)
In-Reply-To: <20171027232242.10574-3-rv@rasmusvillemoes.dk>
I applied these patches and then had to revert this one because a lot of
Smatch was written with the assumption that we could figure out the type
promotion from calling get_type() on the comparison condition...
regards,
dan carpenter
next prev parent reply other threads:[~2017-10-31 12:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-27 23:22 [PATCH 0/3] type fixes, printf warning Rasmus Villemoes
2017-10-27 23:22 ` [PATCH 1/3] smatch_type.c: fix type of pointer diff Rasmus Villemoes
2017-10-27 23:22 ` [PATCH 2/3] smatch_type.c: comparison expressions always have type int Rasmus Villemoes
2017-10-31 12:14 ` Dan Carpenter [this message]
2017-10-27 23:22 ` [PATCH 3/3] check_kernel_printf.c: warn about "%lx", (long)ptr Rasmus Villemoes
2017-10-27 23:25 ` Rasmus Villemoes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171031121444.outrqs2no7z35dyr@mwanda \
--to=dan.carpenter@oracle.com \
--cc=rv@rasmusvillemoes.dk \
--cc=smatch@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).