From: James Carter <jwcart2@gmail.com>
To: cgzones@googlemail.com
Cc: selinux@vger.kernel.org
Subject: Re: [PATCH 1/4] libsepol: improve policy lookup failure message
Date: Thu, 2 May 2024 14:03:56 -0400 [thread overview]
Message-ID: <CAP+JOzTUuKC43nGDSuaP6LsrO0J3=gXP3CRg0_sdBOQvC6sKMA@mail.gmail.com> (raw)
In-Reply-To: <CAP+JOzSk1oNHeLDS9W=94j1+GH9CjwPuMiKvKSp2D=ja==7kdg@mail.gmail.com>
On Mon, Apr 22, 2024 at 4:48 PM James Carter <jwcart2@gmail.com> wrote:
>
> On Mon, Apr 8, 2024 at 11:08 AM Christian Göttsche
> <cgoettsche@seltendoof.de> wrote:
> >
> > From: Christian Göttsche <cgzones@googlemail.com>
> >
> > If a policy version cannot be found include the policy target, and a
> > module prefix for non kernel policies in the message.
> >
> > Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
>
> For these four patches:
> Acked-by: James Carter <jwcart2@gmail.com>
>
These four patches have been merged.
Thanks,
Jim
> > ---
> > libsepol/src/write.c | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/libsepol/src/write.c b/libsepol/src/write.c
> > index 283d11c8..2fcc1701 100644
> > --- a/libsepol/src/write.c
> > +++ b/libsepol/src/write.c
> > @@ -2252,8 +2252,10 @@ int policydb_write(policydb_t * p, struct policy_file *fp)
> > info = policydb_lookup_compat(p->policyvers, p->policy_type,
> > p->target_platform);
> > if (!info) {
> > - ERR(fp->handle, "compatibility lookup failed for policy "
> > - "version %d", p->policyvers);
> > + ERR(fp->handle, "compatibility lookup failed for %s%s policy version %d",
> > + p->target_platform == SEPOL_TARGET_SELINUX ? "selinux" : "xen",
> > + p->policy_type == POLICY_KERN ? "" : " module",
> > + p->policyvers);
> > return POLICYDB_ERROR;
> > }
> >
> > --
> > 2.43.0
> >
> >
prev parent reply other threads:[~2024-05-02 18:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-08 15:07 [PATCH 1/4] libsepol: improve policy lookup failure message Christian Göttsche
2024-04-08 15:08 ` [PATCH 2/4] checkpolicy/tests: add test for splitting xperm rule Christian Göttsche
2024-04-08 15:08 ` [PATCH 3/4] checkpolicy: declare file local variable static Christian Göttsche
2024-04-08 15:08 ` [PATCH 4/4] checkpolicy: drop global policyvers variable Christian Göttsche
2024-04-22 20:48 ` [PATCH 1/4] libsepol: improve policy lookup failure message James Carter
2024-05-02 18:03 ` James Carter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP+JOzTUuKC43nGDSuaP6LsrO0J3=gXP3CRg0_sdBOQvC6sKMA@mail.gmail.com' \
--to=jwcart2@gmail.com \
--cc=cgzones@googlemail.com \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).