From: Ondrej Mosnacek <omosnace@redhat.com>
To: Stephen Smalley <stephen.smalley.work@gmail.com>
Cc: Alan Wandke <alanwandke.linux@gmail.com>,
selinux@vger.kernel.org, paul@paul-moore.com
Subject: Re: [PATCH testsuite] defconfig: add NF_TABLES dependency for netlink_socket tests to pass
Date: Tue, 28 Nov 2023 10:22:16 +0100 [thread overview]
Message-ID: <CAFqZXNtGB=Qzc_p1E-HEoUhP25-O8Cqu6P_zGdyCu1ti2hNHng@mail.gmail.com> (raw)
In-Reply-To: <CAEjxPJ7yi4vs16bKaxErYNd4tDRE1O3Utn73tApNsFdy1pa17Q@mail.gmail.com>
On Mon, Nov 27, 2023 at 9:51 PM Stephen Smalley
<stephen.smalley.work@gmail.com> wrote:
>
> On Mon, Nov 27, 2023 at 12:36 PM Alan Wandke <alanwandke.linux@gmail.com> wrote:
> >
> > In order to support the NETFILTER_NETLINK protocol, either NF_TABLES or IP_SET must be enabled.
> > Neither are strict dependencies in Kconfig. Fix this by enabling NF_TABLES in the defconfig.
> >
> > Before:
> > ./netlinkcreate: socket(AF_NETLINK, SOCK_DGRAM, netfilter/12): Protocol not supported
> > not ok 3
> > # Test 3 got: "256" (./test at line 25)
> > # Expected: "0"
> > # ./test line 25 is: ok( $result, 0 );
> >
> > After:
> > ok 3
> >
> > Signed-off-by: Alan Wandke <alanwandke.linux@gmail.com>
>
> Looks like we could enable it via a number of different config options
> but we need NF_TABLES regardless for the secmark tests in inet_socket
> and sctp to run, so adding that to the defconfig makes the most sense.
>
> Reviewed-by: Stephen Smalley <stephen.smalley.work@gmail.com>
Seems reasonable, thanks! The patch is now applied:
https://github.com/SELinuxProject/selinux-testsuite/commit/fa65d2f59c4d974ef736bc1cd3bfab75b78ac5f0
--
Ondrej Mosnacek
Senior Software Engineer, Linux Security - SELinux kernel
Red Hat, Inc.
prev parent reply other threads:[~2023-11-28 9:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 17:35 [PATCH testsuite] defconfig: add NF_TABLES dependency for netlink_socket tests to pass Alan Wandke
2023-11-27 20:51 ` Stephen Smalley
2023-11-28 9:22 ` Ondrej Mosnacek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFqZXNtGB=Qzc_p1E-HEoUhP25-O8Cqu6P_zGdyCu1ti2hNHng@mail.gmail.com' \
--to=omosnace@redhat.com \
--cc=alanwandke.linux@gmail.com \
--cc=paul@paul-moore.com \
--cc=selinux@vger.kernel.org \
--cc=stephen.smalley.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).