From: Mark Brown <broonie@kernel.org>
To: Paul Moore <paul@paul-moore.com>
Cc: "Aishwarya TCV" <aishwarya.tcv@arm.com>,
linux-security-module@vger.kernel.org, selinux@vger.kernel.org,
"Casey Schaufler" <casey@schaufler-ca.com>,
"John Johansen" <john.johansen@canonical.com>,
"Mickaël Salaün" <mic@digikod.net>,
"Kees Cook" <keescook@chromium.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
linux-hardening@vger.kernel.org
Subject: Re: [RFC PATCH 3/3] lsm: consolidate buffer size handling into lsm_fill_user_ctx()
Date: Thu, 21 Dec 2023 18:50:35 +0000 [thread overview]
Message-ID: <2ef211af-95b8-49cf-8c11-1d8b958799b7@sirena.org.uk> (raw)
In-Reply-To: <CAHC9VhSZ6SQ=2tspLk+kFhXKPoOcAcGzkVrWVneT5_cXBUyrUQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 984 bytes --]
On Thu, Dec 21, 2023 at 10:21:04AM -0500, Paul Moore wrote:
> On Thu, Dec 21, 2023 at 8:01 AM Mark Brown <broonie@kernel.org> wrote:
> > On Wed, Dec 20, 2023 at 08:40:24PM -0500, Paul Moore wrote:
> > > Suggestions on how to annotate the struct, or the code doing the
> > > memcpy() are welcome.
> > You're looking for a __counted_by() annotation here I think.
> Can you verify and submit a patch for that? I'm asking because my
> build/toolchain configuration never produced these warnings/errors
> during my testing.
Huh, actually it's not __counted_by() since this shows up with
arm64/gcc-10 (and some other arches) which doesn't have that. I'll
submit the __counted_by() patch anyway since it's clearly a good
annotation but it doesn't actually shut the warning up in this case.
Adding the hardening people, and I'll have a further look.
You can reproduce with
tuxmake -r docker -k defconfig -a arm64 -t gcc-10
using https://www.tuxmake.org/
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-12-21 18:50 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 21:35 [RFC PATCH 0/3] LSM syscall tweaks Paul Moore
2023-10-24 21:35 ` [RFC PATCH 1/3] lsm: cleanup the size counters in security_getselfattr() Paul Moore
2023-10-24 22:23 ` Casey Schaufler
2023-10-25 1:43 ` Paul Moore
2023-10-25 15:19 ` Casey Schaufler
2023-10-25 22:06 ` Paul Moore
2023-10-26 14:59 ` Mickaël Salaün
2023-10-24 21:35 ` [RFC PATCH 2/3] lsm: correct error codes " Paul Moore
2023-10-24 22:23 ` Casey Schaufler
2023-10-26 15:00 ` Mickaël Salaün
2023-10-24 21:35 ` [RFC PATCH 3/3] lsm: consolidate buffer size handling into lsm_fill_user_ctx() Paul Moore
2023-10-26 15:13 ` Mickaël Salaün
2023-10-26 15:38 ` Paul Moore
2023-12-20 22:31 ` Aishwarya TCV
2023-12-21 1:40 ` Paul Moore
2023-12-21 13:01 ` Mark Brown
2023-12-21 15:21 ` Paul Moore
2023-12-21 18:50 ` Mark Brown [this message]
2023-11-01 21:24 ` [RFC PATCH 0/3] LSM syscall tweaks Paul Moore
2023-11-01 22:26 ` Casey Schaufler
2023-11-13 4:07 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ef211af-95b8-49cf-8c11-1d8b958799b7@sirena.org.uk \
--to=broonie@kernel.org \
--cc=aishwarya.tcv@arm.com \
--cc=casey@schaufler-ca.com \
--cc=gustavoars@kernel.org \
--cc=john.johansen@canonical.com \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mic@digikod.net \
--cc=paul@paul-moore.com \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).