From: "Christian Göttsche" <cgzones@googlemail.com>
To: selinux@vger.kernel.org
Subject: [PATCH] libsepol: validate common classes have at least one permissions
Date: Mon, 13 Nov 2023 20:26:32 +0100 [thread overview]
Message-ID: <20231113192632.22509-1-cgzones@googlemail.com> (raw)
The traditional language and CIL permit common classes only to be
defined with at least one permission. Thus writing a common class
without one will fail.
Reported-by: oss-fuzz (issue 64059)
Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
---
libsepol/src/policydb_validate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libsepol/src/policydb_validate.c b/libsepol/src/policydb_validate.c
index 016ab655..1121c8bb 100644
--- a/libsepol/src/policydb_validate.c
+++ b/libsepol/src/policydb_validate.c
@@ -369,7 +369,7 @@ static int validate_common_datum(sepol_handle_t *handle, const common_datum_t *c
{
if (validate_value(common->s.value, &flavors[SYM_COMMONS]))
goto bad;
- if (common->permissions.nprim > PERM_SYMTAB_SIZE)
+ if (common->permissions.table->nel == 0 || common->permissions.nprim > PERM_SYMTAB_SIZE)
goto bad;
return 0;
--
2.42.0
next reply other threads:[~2023-11-13 19:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 19:26 Christian Göttsche [this message]
2023-11-14 20:40 ` [PATCH] libsepol: validate common classes have at least one permissions James Carter
2023-11-16 14:57 ` James Carter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231113192632.22509-1-cgzones@googlemail.com \
--to=cgzones@googlemail.com \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).