SELinux-Refpolicy Archive mirror
 help / color / mirror / Atom feed
From: Dominick Grift <dominick.grift@defensec.nl>
To: Nicolas Iooss <nicolas.iooss@m4x.org>
Cc: Russell Coker <russell@coker.com.au>,
	Chris PeBenito <pebenito@ieee.org>,
	refpolicy <selinux-refpolicy@vger.kernel.org>
Subject: Re: [PATCH] misc services patches with changes Dominick and Chris wanted
Date: Thu, 28 Jan 2021 18:41:50 +0100	[thread overview]
Message-ID: <ypjla6sthsbl.fsf@defensec.nl> (raw)
In-Reply-To: <CAJfZ7===nm6YpDnjH4WQko=O=NS5z3pFb82crq4++JimUsxHYA@mail.gmail.com> (Nicolas Iooss's message of "Thu, 28 Jan 2021 18:34:41 +0100")

Nicolas Iooss <nicolas.iooss@m4x.org> writes:

> On Thu, Jan 28, 2021 at 6:07 PM Dominick Grift
> <dominick.grift@defensec.nl> wrote:
>>
>> Chris PeBenito <pebenito@ieee.org> writes:
>>
>> > On 1/26/21 10:15 PM, Russell Coker wrote:
>> >> I think this one is ready to merge.
>> >> Signed-off-by: Russell Coker <russell@coker.com.au>
>> >
>> >
>> >> @@ -170,6 +172,7 @@ ifdef(`distro_suse',`
>> >>   /var/log/roundcubemail(/.*)?
>> >> gen_context(system_u:object_r:httpd_log_t,s0)
>> >>   /var/log/suphp\.log.* --
>> >> gen_context(system_u:object_r:httpd_log_t,s0)
>> >>   /var/log/z-push(/.*)?
>> >> gen_context(system_u:object_r:httpd_sys_rw_content_t,s0)
>> >> +/var/log/php7..-fpm.log --
>> >> gen_context(system_u:object_r:httpd_log_t,s0)
>> >
>> > selint flagged this.  Is ".." intended to be 2 "." metacharacters?
>>
>> I would probably just do: /var/log/php.*-fpm\.log.* and get it over with
>
> Or /var/log/php[0-9.]+-fpm\.log to match "something that looks like a
> version". The problem with "." is that it can match a "/", for
> subdirectories.

BTW One might wonder why i use the .* suffix. That is to support log rotation.

>
> Nicolas
>

-- 
gpg --locate-keys dominick.grift@defensec.nl
Key fingerprint = FCD2 3660 5D6B 9D27 7FC6  E0FF DA7E 521F 10F6 4098
https://sks-keyservers.net/pks/lookup?op=get&search=0xDA7E521F10F64098
Dominick Grift

      reply	other threads:[~2021-01-28 17:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-27  3:15 [PATCH] misc services patches with changes Dominick and Chris wanted Russell Coker
2021-01-28 15:50 ` Chris PeBenito
2021-01-28 16:56 ` Chris PeBenito
2021-01-28 16:59   ` Russell Coker
2021-01-28 17:04   ` Dominick Grift
2021-01-28 17:34     ` Nicolas Iooss
2021-01-28 17:41       ` Dominick Grift [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ypjla6sthsbl.fsf@defensec.nl \
    --to=dominick.grift@defensec.nl \
    --cc=nicolas.iooss@m4x.org \
    --cc=pebenito@ieee.org \
    --cc=russell@coker.com.au \
    --cc=selinux-refpolicy@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).