From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Trevor Gross" <tmgross@umich.edu>, "Obei Sideg" <linux@obei.io>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Wedson Almeida Filho" <wedsonaf@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Andreas Hindborg" <a.hindborg@samsung.com>,
"Alice Ryhl" <aliceryhl@google.com>,
"rust-for-linux@vger.kernel.org" <rust-for-linux@vger.kernel.org>,
"Matt Gilbride" <mattgilbride@google.com>
Subject: Re: [PATCH] rust: types: Add `try_from_foreign()` method
Date: Tue, 23 Jan 2024 09:10:13 +0000 [thread overview]
Message-ID: <CYLYVXYNETD2.11ZTBC8IY529S@seitikki> (raw)
In-Reply-To: <CALNs47v_2LxKnpWRYnM0Jcj+wdzPFQcfuaHyh_GnbLgNDXHLZw@mail.gmail.com>
On Mon Jan 22, 2024 at 8:33 PM UTC, Trevor Gross wrote:
> On Mon, Jan 22, 2024 at 2:11 PM Obei Sideg <linux@obei.io> wrote:
> >
> > Currently `ForeignOwnable::from_foreign()` only
> > works for non-null pointers for the existing
> > impls (e.g. Box, Arc). It may create a few
> > duplicate code like:
>
> Minor nit: commit messages are wrapped to 72 characters, looks like this is 50.
It is actually 75 characters max:
"The body of the explanation, line wrapped at 75 columns, which will be
copied to the permanent changelog to describe this patch."
See https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the-canonical-patch-format
BR, Jarkko
next prev parent reply other threads:[~2024-01-23 9:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240122162553.64610-1-linux@obei.io>
2024-01-22 16:26 ` [PATCH] rust: types: Add `try_from_foreign()` method Obei Sideg
2024-01-22 18:14 ` Martin Rodriguez Reboredo
2024-01-22 20:33 ` Trevor Gross
2024-01-22 22:01 ` Trevor Gross
2024-01-23 9:10 ` Jarkko Sakkinen [this message]
2024-01-22 21:14 ` Alice Ryhl
[not found] <20240123082746.18284-1-linux@obei.io>
2024-01-23 8:28 ` Obei Sideg
2024-01-23 12:09 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CYLYVXYNETD2.11ZTBC8IY529S@seitikki \
--to=jarkko@kernel.org \
--cc=a.hindborg@samsung.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=linux@obei.io \
--cc=mattgilbride@google.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).