Rust-for-linux archive mirror
 help / color / mirror / Atom feed
From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Dirk Behme <dirk.behme@de.bosch.com>
Cc: rust-for-linux@vger.kernel.org, Trevor Gross <tmgross@umich.edu>,
	 Miguel Ojeda <ojeda@kernel.org>
Subject: Re: [PATCH v3 2/2] docs: rust: Add description of Rust documentation test as KUnit ones
Date: Mon, 29 Jan 2024 18:51:19 +0100	[thread overview]
Message-ID: <CANiq72nvTp+yQ3s+cv9=dxO7q3jv_iFpbVjxh3r6LLxQrfaO8g@mail.gmail.com> (raw)
In-Reply-To: <20240125065551.2436403-2-dirk.behme@de.bosch.com>

On Thu, Jan 25, 2024 at 7:56 AM Dirk Behme <dirk.behme@de.bosch.com> wrote:
>
> Changes in v3:
>  * Got the '?' operator link to work :)
>  * Rebased against v6.8-rc1

Great, thanks for both :)

> +This are the tests that come from the examples in the Rust documentation
> +and get transformed into KUnit tests.

Typo: "This".

I would also perhaps say "...documentation. They get transformed..."
instead so that it is clear there is not another set of doctests that
are not transformed.

Cheers,
Miguel

  parent reply	other threads:[~2024-01-29 17:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-25  6:55 [PATCH v3 1/2] docs: rust: Move testing to a separate page Dirk Behme
2024-01-25  6:55 ` [PATCH v3 2/2] docs: rust: Add description of Rust documentation test as KUnit ones Dirk Behme
2024-01-25  7:09   ` David Gow
2024-01-29 11:27   ` Alice Ryhl
2024-01-29 17:51   ` Miguel Ojeda [this message]
2024-01-25  7:09 ` [PATCH v3 1/2] docs: rust: Move testing to a separate page David Gow
2024-01-29 11:27 ` Alice Ryhl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANiq72nvTp+yQ3s+cv9=dxO7q3jv_iFpbVjxh3r6LLxQrfaO8g@mail.gmail.com' \
    --to=miguel.ojeda.sandonis@gmail.com \
    --cc=dirk.behme@de.bosch.com \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).