From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Danilo Krummrich <dakr@redhat.com>
Cc: Boqun Feng <boqun.feng@gmail.com>,
ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com,
gary@garyguo.net, bjorn3_gh@protonmail.com,
benno.lossin@proton.me, a.hindborg@samsung.com,
aliceryhl@google.com, rust-for-linux@vger.kernel.org
Subject: Re: [PATCH] rust: alloc: fix dangling pointer in VecExt<T>::reserve()
Date: Wed, 1 May 2024 00:44:12 +0200 [thread overview]
Message-ID: <CANiq72k_eciLRuJ=nyoeP2gHBvcgr2s9aftPrFHiavPTrgDaHw@mail.gmail.com> (raw)
In-Reply-To: <8b68878e-2ddd-4f31-9f82-4abe638bf148@redhat.com>
On Mon, Apr 29, 2024 at 11:01 PM Danilo Krummrich <dakr@redhat.com> wrote:
>
> I'd be surprised if rust-next wouldn't be fast-forward only, is it? If
Like most branches, it is generally not rebased, but it can be if
there is a good reason for it, i.e. there is no hard guarantee, and
rebases indeed happen sometimes, and they are allowed for branches in
linux-next (again, when deemed necessary).
> As for squashing fixes into existing commits, this is something I would generally
> not recommend doing. This would be a non-fast-forward operation and hence break
> potential references to other commits in general (not only "Fixes" tags). Plus,
It is a judgment call. It depends on how serious the mistake is and
how costly rebasing is, which in turn depends on the branch in
question, its state, its expected users, the testing time one would
lose, etc.
In this case, to be practical: does anybody think that the risk of
getting bisected here and hitting the issue (especially with the code
we have so far in-tree, i.e. the `T`s that would apply here) is high?
> it's usually not providing a great motivation for potential contributors.
Credit can (and should) still be given even in that case.
But, yes, for e.g. a new contributor to the kernel looking for their
first actual commit, it could be a big deal.
Cheers,
Miguel
next prev parent reply other threads:[~2024-04-30 22:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 19:24 [PATCH] rust: alloc: fix dangling pointer in VecExt<T>::reserve() Danilo Krummrich
2024-04-29 19:52 ` Boqun Feng
2024-04-29 21:01 ` Danilo Krummrich
2024-04-29 22:01 ` Boqun Feng
2024-04-30 16:42 ` Danilo Krummrich
2024-04-30 18:33 ` Boqun Feng
2024-04-30 20:46 ` Danilo Krummrich
2024-04-30 20:59 ` Boqun Feng
2024-04-30 21:08 ` Boqun Feng
2024-04-30 22:19 ` Danilo Krummrich
2024-04-30 22:41 ` Boqun Feng
2024-04-30 22:06 ` Boqun Feng
2024-04-30 22:44 ` Miguel Ojeda [this message]
2024-04-30 8:25 ` Alice Ryhl
2024-04-30 12:07 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANiq72k_eciLRuJ=nyoeP2gHBvcgr2s9aftPrFHiavPTrgDaHw@mail.gmail.com' \
--to=miguel.ojeda.sandonis@gmail.com \
--cc=a.hindborg@samsung.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@redhat.com \
--cc=gary@garyguo.net \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).