From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: dev@raxyte.com
Cc: ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com,
boqun.feng@gmail.com, gary@garyguo.net,
bjorn3_gh@protonmail.com, benno.lossin@proton.me,
a.hindborg@samsung.com, aliceryhl@google.com,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rust: update `dbg!()` to format column number
Date: Mon, 6 May 2024 00:28:35 +0200 [thread overview]
Message-ID: <CANiq72=+iRTiL5Aisvq9Bea4FegF5CmHCLjn9AYPormgtwb62g@mail.gmail.com> (raw)
In-Reply-To: <eba70259-9b10-4bf7-ac4f-d7accf6b8891@smtp-relay.sendinblue.com>
On Sun, Apr 14, 2024 at 3:21 PM <dev@raxyte.com> wrote:
>
> In Rust 1.76.0, the `dbg!()` macro was updated to also format the column
> number. The reason cited was usage of a few characters worth of
> horizontal space while allowing direct jumps to the source location. [1]
>
> Link: https://github.com/rust-lang/rust/pull/114962 [1]
> Link: https://github.com/Rust-for-Linux/linux/issues/1065
>
> Signed-off-by: Raghav Narang <dev@raxyte.com>
The commit author was:
dev@raxyte.com <dev@raxyte.com>
and I fixed it to:
Raghav Narang <dev@raxyte.com>
i.e. with the name from the Signed-off-by line. If this is not
correct, please let me know!
[ Fixed commit author name and removed spurious newline in message. - Miguel ]
Applied to `rust-next` -- thanks everyone!
Cheers,
Miguel
prev parent reply other threads:[~2024-05-05 22:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-14 13:19 [PATCH] rust: update `dbg!()` to format column number dev
2024-04-16 5:58 ` Trevor Gross
2024-04-16 9:34 ` Miguel Ojeda
2024-04-17 13:50 ` Gary Guo
2024-05-05 22:28 ` Miguel Ojeda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANiq72=+iRTiL5Aisvq9Bea4FegF5CmHCLjn9AYPormgtwb62g@mail.gmail.com' \
--to=miguel.ojeda.sandonis@gmail.com \
--cc=a.hindborg@samsung.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dev@raxyte.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).