From: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: ojeda@kernel.org, rust-for-linux@vger.kernel.org,
Kartik Prajapati <kartikprajapati987@gmail.com>
Subject: Re: [PATCH v1] rust: kernel: types: Add `ARef::into_raw`
Date: Fri, 29 Mar 2024 21:11:25 +0100 [thread overview]
Message-ID: <CAKy8djQjYNS5hmyJ=rZLuGj3jDrtn0QEpF_buo8NucoCqRiXWQ@mail.gmail.com> (raw)
In-Reply-To: <CANiq72==OBG+KVJuzW0S5aYowAZ4oq91pk=phRgtedUrGYeHAg@mail.gmail.com>
> Hi Vincenzo,
>
> Thanks for sending this!
>
> (This is a resend -- apparently vger has had some delays for the last
> ~14 hours or so.)
Yeah sorry about the double posting on the ML, but looks like that now
all is fine.
Thanks
Vincent.
>
> On Mon, Mar 25, 2024 at 12:05 PM Vincenzo Palazzo
> <vincenzopalazzodev@gmail.com> wrote:
> >
> > Add the function `into_raw` to `ARef<T>`. This method
> > can be used to turn an `ARef` into a raw pointer.
> >
> > Link: https://github.com/Rust-for-Linux/linux/issues/1044
> > Co-developed-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
> > Signed-off-by: Kartik Prajapati <kartikprajapati987@gmail.com>
> > Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
>
> Given what you wrote here, I think you intended to give the primary
> authorship to Kartik, right? If that is the case, that would require a
> different ordering of these lines (like the last example at
> https://docs.kernel.org/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by):
>
> Signed-off-by: Kartik Prajapati <kartikprajapati987@gmail.com>
> Co-developed-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
> Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
>
> In addition, the commit should be properly attributed to Kartik in
> Git, which means you will automatically get the `From: Kartik ...`
> line too that you see in the example of the documentation I linked
> above.
>
> However, from what I can tell, you didn't modify the commit from
> Kartik at all. If that is correct, then the `Co-developed-by` should
> not be there (https://docs.kernel.org/process/submitting-patches.html#developer-s-certificate-of-origin-1-1
> has the details).
>
> Finally, for v2, could you please To/Cc the rest of the
> maintainers/reviewers? You can use `scripts/get_maintainer.pl` for
> that, or the couple commands at
> https://rust-for-linux.com/contributing#submitting-patches.
>
> Thanks!
>
> Cheers,
> Miguel
next prev parent reply other threads:[~2024-03-29 20:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 11:04 [PATCH v1] rust: kernel: types: Add `ARef::into_raw` Vincenzo Palazzo
2024-03-25 14:10 ` Miguel Ojeda
2024-03-29 20:11 ` Vincenzo Palazzo [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-03-24 23:12 Vincenzo Palazzo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKy8djQjYNS5hmyJ=rZLuGj3jDrtn0QEpF_buo8NucoCqRiXWQ@mail.gmail.com' \
--to=vincenzopalazzodev@gmail.com \
--cc=kartikprajapati987@gmail.com \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).