From: Laine Taffin Altman <alexanderaltman@me.com>
To: Benno Lossin <benno.lossin@proton.me>
Cc: "Miguel Ojeda" <miguel.ojeda.sandonis@gmail.com>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
rust-for-linux@vger.kernel.org,
"Wedson Almeida Filho" <wedsonaf@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Andreas Hindborg" <a.hindborg@samsung.com>,
"Alice Ryhl" <aliceryhl@google.com>,
"Martin Rodriguez Reboredo" <yakoyoku@gmail.com>,
lkml <linux-kernel@vger.kernel.org>,
stable@vger.kernel.org
Subject: Re: [PATCH v4] rust: init: remove impl Zeroable for Infallible
Date: Sun, 7 Apr 2024 10:55:49 -0700 [thread overview]
Message-ID: <37A7EC35-7889-4378-A30C-126B1AD668C8@me.com> (raw)
In-Reply-To: <3ecba34f-95a2-4f18-9729-f9cb3a4366c0@proton.me>
On Apr 7, 2024, at 1:56 AM, Benno Lossin <benno.lossin@proton.me> wrote:
> On 04.04.24 19:28, Laine Taffin Altman wrote:
>>> On Apr 4, 2024, at 4:03 AM, Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> wrote:
>>>
>>> On Thu, Apr 4, 2024 at 11:01 AM Benno Lossin <benno.lossin@proton.me> wrote:
>>>>
>>>> I don't see this commit in the kernel tree, what did you specify as
>>>> `--base` when running `git format`?
>>>
>>> Yeah, I don't have it either, but it seems to apply cleanly.
>>>
>>> Cheers,
>>> Miguel
>>
>> I ran `git format-patch origin/master --base=origin/master`. I
>> can’t imagine how that could have resulted in a nonexistent commit
>> hash?
>
> That heavily depends on what `origin/master` is. Is `origin` pointing to
> Torvald's git? In that case it would explain why we don't have that
> commit hash yet.
> Normally you should base your work on the tree listed in the `T:` entry
> of the subsystem in the MAINTAINERS file. In our case it is `rust-next`.
> But no worries, since it applies cleanly it should be fine for this
> patch. Just something to keep in mind if you submit any future patches.
>
> --
> Cheers,
> Benno
Ah, that makes sense! Indeed it was pointing there. I’ll remember for next time!
Thanks,
Laine
next prev parent reply other threads:[~2024-04-07 17:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-03 21:06 [PATCH v4] rust: init: remove impl Zeroable for Infallible Laine Taffin Altman
2024-04-04 9:01 ` Benno Lossin
2024-04-04 11:02 ` Miguel Ojeda
2024-04-04 17:28 ` Laine Taffin Altman
2024-04-07 8:56 ` Benno Lossin
2024-04-07 17:55 ` Laine Taffin Altman [this message]
2024-04-04 11:07 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37A7EC35-7889-4378-A30C-126B1AD668C8@me.com \
--to=alexanderaltman@me.com \
--cc=a.hindborg@samsung.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=wedsonaf@gmail.com \
--cc=yakoyoku@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).