From: FUJITA Tomonori <fujita.tomonori@gmail.com>
To: rust-for-linux@vger.kernel.org
Subject: [PATCH RFC v1] rust: add 'firmware' tag support to module! macro
Date: Fri, 19 Apr 2024 22:53:53 +0900 (JST) [thread overview]
Message-ID: <20240419.225353.364631939354183191.fujita.tomonori@gmail.com> (raw)
Hi,
This patch is necessary for a new QT2025 PHY driver in Rust:
https://lwn.net/Articles/969888/
Are there places to be fixed or imporved before sending this in the v2
of the PHY driver patchset?
-
This adds 'firmware' tag support to module! macro, corresponds to
MODULE_FIRMWARE macro.
A module can have multiple 'firmware' tags like 'alias'.
Signed-off-by: FUJITA Tomonori <fujita.tomonori@gmail.com>
---
rust/macros/module.rs | 18 ++++++++++++++++--
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/rust/macros/module.rs b/rust/macros/module.rs
index 27979e582e4b..5fdaac17a733 100644
--- a/rust/macros/module.rs
+++ b/rust/macros/module.rs
@@ -97,14 +97,22 @@ struct ModuleInfo {
author: Option<String>,
description: Option<String>,
alias: Option<Vec<String>>,
+ firmware: Option<Vec<String>>,
}
impl ModuleInfo {
fn parse(it: &mut token_stream::IntoIter) -> Self {
let mut info = ModuleInfo::default();
- const EXPECTED_KEYS: &[&str] =
- &["type", "name", "author", "description", "license", "alias"];
+ const EXPECTED_KEYS: &[&str] = &[
+ "type",
+ "name",
+ "author",
+ "description",
+ "license",
+ "alias",
+ "firmware",
+ ];
const REQUIRED_KEYS: &[&str] = &["type", "name", "license"];
let mut seen_keys = Vec::new();
@@ -131,6 +139,7 @@ fn parse(it: &mut token_stream::IntoIter) -> Self {
"description" => info.description = Some(expect_string(it)),
"license" => info.license = expect_string_ascii(it),
"alias" => info.alias = Some(expect_string_array(it)),
+ "firmware" => info.firmware = Some(expect_string_array(it)),
_ => panic!(
"Unknown key \"{}\". Valid keys are: {:?}.",
key, EXPECTED_KEYS
@@ -186,6 +195,11 @@ pub(crate) fn module(ts: TokenStream) -> TokenStream {
modinfo.emit("alias", &alias);
}
}
+ if let Some(firmware) = info.firmware {
+ for fw in firmware {
+ modinfo.emit("firmware", &fw);
+ }
+ }
// Built-in modules also export the `file` modinfo string.
let file =
--
2.34.1
next reply other threads:[~2024-04-19 13:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 13:53 FUJITA Tomonori [this message]
2024-04-19 14:11 ` [PATCH RFC v1] rust: add 'firmware' tag support to module! macro Greg KH
2024-04-19 16:41 ` Benno Lossin
2024-04-20 1:14 ` FUJITA Tomonori
2024-04-25 15:35 ` Benno Lossin
2024-04-26 1:10 ` FUJITA Tomonori
2024-04-26 7:11 ` Benno Lossin
2024-04-26 7:21 ` Miguel Ojeda
2024-04-26 9:40 ` FUJITA Tomonori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240419.225353.364631939354183191.fujita.tomonori@gmail.com \
--to=fujita.tomonori@gmail.com \
--cc=rust-for-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).