From: Conor Dooley <conor@kernel.org>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: "Conor Dooley" <conor.dooley@microchip.com>,
linux-riscv@lists.infradead.org,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Wedson Almeida Filho" <wedsonaf@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Nathan Chancellor" <nathan@kernel.org>,
"Nick Desaulniers" <ndesaulniers@google.com>,
"Tom Rix" <trix@redhat.com>,
rust-for-linux@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH v2 2/3] scripts: generate_rust_target: enable building on RISC-V
Date: Tue, 27 Feb 2024 18:24:06 +0000 [thread overview]
Message-ID: <20240227-aside-limeade-497fb182a5bd@spud> (raw)
In-Reply-To: <CANiq72kQ8===wFLQNCR-XAo9KdtPr44UKvyi2074J88vh3kvyg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1161 bytes --]
On Tue, Feb 27, 2024 at 07:11:17PM +0100, Miguel Ojeda wrote:
> On Tue, Feb 27, 2024 at 6:48 PM Conor Dooley <conor@kernel.org> wrote:
> For instance, to disable the compressed instructions, from what I can
> tell, the flag I mentioned seems to work, so that is fine.
To me, using flags is a good fit given that's what we do elsewhere,
and there won't be a mix of stuff that is done conditionally in a
script and conditionally in a Makefile.
> However,
> for something like tweaking the data layout for `n64` instead of
> `n32:64`, I am not aware of a way to do so via a flag (but I see newer
> LLVM uses `n32:64`, so that may be the better one anyway:
> https://godbolt.org/z/Eh4cfdeMr).
Yeah, I had looked at the blame for the targets earlier today and
noticed that it had been changed. Sadly rustc's commit is lacking
any justification whatsoever for the change, so I was not going to
really comment on that until I had looked.
> So it all depends on whether you are happy with what the flags
> approach already give you.
>
> I hope that clarifies a bit!
Ye, thanks. I'll give it a go when I have a bit of time this week.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-02-27 18:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 13:38 [PATCH v2 0/3] RISC-V: enable rust Conor Dooley
2024-02-23 13:38 ` [PATCH v2 1/3] rust: make mutually exclusive with CFI_CLANG Conor Dooley
2024-02-23 14:45 ` Miguel Ojeda
2024-02-27 10:53 ` Conor Dooley
2024-02-27 12:34 ` Miguel Ojeda
2024-02-27 13:02 ` Conor Dooley
2024-02-27 13:30 ` Conor Dooley
2024-02-23 13:38 ` [PATCH v2 2/3] scripts: generate_rust_target: enable building on RISC-V Conor Dooley
2024-02-23 14:39 ` Miguel Ojeda
2024-02-27 10:16 ` Conor Dooley
2024-02-27 10:46 ` Miguel Ojeda
2024-02-27 11:04 ` Conor Dooley
2024-02-27 12:12 ` Miguel Ojeda
2024-02-27 12:36 ` Conor Dooley
2024-02-27 14:47 ` Miguel Ojeda
2024-02-27 17:48 ` Conor Dooley
2024-02-27 18:11 ` Miguel Ojeda
2024-02-27 18:24 ` Conor Dooley [this message]
2024-02-23 13:38 ` [PATCH v2 3/3] RISC-V: enable building 64-bit kernels with rust support Conor Dooley
2024-02-23 14:48 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240227-aside-limeade-497fb182a5bd@spud \
--to=conor@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=conor.dooley@microchip.com \
--cc=corbet@lwn.net \
--cc=gary@garyguo.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=llvm@lists.linux.dev \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=ojeda@kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=trix@redhat.com \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).