From: Jan Kara <jack@suse.cz>
To: Tom Rix <trix@redhat.com>
Cc: nathan@kernel.org, ndesaulniers@google.com, axboe@kernel.dk,
akpm@linux-foundation.org, bvanassche@acm.org, jack@suse.cz,
yi.zhang@huawei.com, reiserfs-devel@vger.kernel.org,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH] reiserfs: remove unused iter variable
Date: Fri, 31 Mar 2023 14:21:46 +0200 [thread overview]
Message-ID: <20230331122146.3rmw3dqv6y573pg2@quack3> (raw)
In-Reply-To: <20230331120325.1855111-1-trix@redhat.com>
On Fri 31-03-23 08:03:25, Tom Rix wrote:
> clang with W=1 reports
> fs/reiserfs/stree.c:1265:6: error: variable
> 'iter' set but not used [-Werror,-Wunused-but-set-variable]
> int iter = 0;
> ^
> This variable is not used so remove it.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Thanks. I've merged the patch to my tree.
Honza
> ---
> fs/reiserfs/stree.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/reiserfs/stree.c b/fs/reiserfs/stree.c
> index 84c12a1947b2..ce5003986789 100644
> --- a/fs/reiserfs/stree.c
> +++ b/fs/reiserfs/stree.c
> @@ -1262,7 +1262,6 @@ int reiserfs_delete_item(struct reiserfs_transaction_handle *th,
>
> #ifdef CONFIG_REISERFS_CHECK
> char mode;
> - int iter = 0;
> #endif
>
> BUG_ON(!th->t_trans_id);
> @@ -1274,7 +1273,6 @@ int reiserfs_delete_item(struct reiserfs_transaction_handle *th,
> removed = 0;
>
> #ifdef CONFIG_REISERFS_CHECK
> - iter++;
> mode =
> #endif
> prepare_for_delete_or_cut(th, inode, path,
> --
> 2.27.0
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
prev parent reply other threads:[~2023-03-31 12:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-31 12:03 [PATCH] reiserfs: remove unused iter variable Tom Rix
2023-03-31 12:21 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230331122146.3rmw3dqv6y573pg2@quack3 \
--to=jack@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=reiserfs-devel@vger.kernel.org \
--cc=trix@redhat.com \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).