From: "Linux regression tracking (Thorsten Leemhuis)" <regressions@leemhuis.info>
To: Carl Huang <quic_cjhuang@quicinc.com>
Cc: Luca Weiss <luca.weiss@fairphone.com>,
ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
regressions@lists.linux.dev, Kalle Valo <kvalo@kernel.org>
Subject: Re: [PATCH 1/2] wifi: ath11k: supports 2 station interfaces
Date: Thu, 16 May 2024 13:45:27 +0200 [thread overview]
Message-ID: <a53e2188-b982-44b7-9dfe-f5dfd6b802ca@leemhuis.info> (raw)
In-Reply-To: <4e21e556-527f-4d1e-aa29-cacec14155af@quicinc.com>
On 11.05.24 05:12, Carl Huang wrote:
> On 2024/5/10 21:57, Kalle Valo wrote:
>> Carl Huang <quic_cjhuang@quicinc.com> writes:
>>> On 2024/5/10 18:18, Kalle Valo wrote:
>>>> "Luca Weiss" <luca.weiss@fairphone.com> writes:
>>>>> On Fri Jul 14, 2023 at 4:38 AM CEST, Carl Huang wrote:
>>>>>> Add hardware parameter support_dual_stations to indicate
>>>>>> whether 2 station interfaces are supported. For chips which
>>>>>> support this feature, limit total number of AP interface and
>>>>>> mesh point to 1. The max interfaces are 3 for such chips.
>>>>>> [...]
>>>>> Unfortunately this commit breaks wifi on a QCM6490 smartphone
>>>>> (qcm6490-fairphone-fp5) and makes the board crash.
>>>>>
>>>>> Reverting this commit (plus for conflict resolution 5dc9d1a55e95
>>>>> ("wifi:
>>>>> ath11k: add support for QCA2066") and 24395ec11707 ("wifi: ath11k:
>>>>> provide address list if chip supports 2 stations")) makes wifi work
>>>>> again.
>>>> Thanks for the report. So the broken commit is:
>>>> f019f4dff2e4 wifi: ath11k: support 2 station interfaces
>>>> This went into v6.9-rc1 so I'm guessing that WCN6750 support will be
>>>> fully broken in v6.9? Not good. And most likely Linus will release v6.9
>>>> on Sunday so it's too late to get a fix included in the final release.
>>>> Carl, can you fix this ASAP? Or should we just revert the broken
>>>> commits?
>>> Kalle, looks we're not able to fix it before Sunday as I don't have
>>> WCN6750 setup to verify the fix.
>> We are so late in the cycle that we would have to send the fix directly
>> to Linus and ask him to apply the fix before he tags the release. I
>> prefer that we are on the safe side here and send the fix to v6.10-rc1
>> via the usual route (the wireless tree). We get more testing time that
>> way.
>>
> No problem, Kalle.
>
> I think more tags are needed like Tested-on WCN6750 and Tested-by Luca.
>
> I'll send out the formal patch next week.
Hmmm, from here it looks like this did not happen. Did I miss something,
is there some reason to reevaluate things again, or did this maybe
simply fall through the cracks?
Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.
#regzbot poke
>>> The fix could be to define a dedicated function
>>> ath11k_init_wmi_config_wcn6750() for WCN6750. I'll send the patch out
>>> so others like Luca can have a try.
>>
>> Thanks for the quick patches!
>>
>
>
next prev parent reply other threads:[~2024-05-16 11:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230714023801.2621802-1-quic_cjhuang@quicinc.com>
[not found] ` <20230714023801.2621802-2-quic_cjhuang@quicinc.com>
[not found] ` <D15TIIDIIESY.D1EKKJLZINMA@fairphone.com>
2024-05-10 10:18 ` [PATCH 1/2] wifi: ath11k: supports 2 station interfaces Kalle Valo
2024-05-10 12:03 ` Carl Huang
2024-05-10 13:04 ` Carl Huang
2024-05-10 13:26 ` Luca Weiss
2024-05-11 2:50 ` Carl Huang
2024-05-10 13:57 ` Kalle Valo
2024-05-11 3:12 ` Carl Huang
2024-05-16 11:45 ` Linux regression tracking (Thorsten Leemhuis) [this message]
2024-05-16 14:11 ` Jeff Johnson
2024-05-17 5:25 ` Kalle Valo
2024-05-17 6:04 ` Thorsten Leemhuis
2024-05-17 7:39 ` Kalle Valo
2024-05-19 17:51 ` Linux regression tracking (Thorsten Leemhuis)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a53e2188-b982-44b7-9dfe-f5dfd6b802ca@leemhuis.info \
--to=regressions@leemhuis.info \
--cc=ath11k@lists.infradead.org \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=quic_cjhuang@quicinc.com \
--cc=regressions@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).