From: Johan Hovold <johan@kernel.org>
To: Christian Brauner <brauner@kernel.org>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: linux-fsdevel@vger.kernel.org,
linux-ntfs-dev@lists.sourceforge.net, ntfs3@lists.linux.dev,
Anton Altaparmakov <anton@tuxera.com>,
Namjae Jeon <linkinjeon@kernel.org>,
regressions@lists.linux.dev
Subject: Re: [PATCH] fs: Remove NTFS classic
Date: Fri, 22 Mar 2024 17:35:09 +0100 [thread overview]
Message-ID: <Zf2zPf5TO5oYt3I3@hovoldconsulting.com> (raw)
In-Reply-To: <20240116-fernbedienung-vorwort-a21384fd7962@brauner>
On Tue, Jan 16, 2024 at 10:33:49AM +0100, Christian Brauner wrote:
> On Mon, 15 Jan 2024 07:20:25 +0000, Matthew Wilcox (Oracle) wrote:
> > The replacement, NTFS3, was merged over two years ago. It is now time to
> > remove the original from the tree as it is the last user of several APIs,
> > and it is not worth changing.
> I see no reason to not at least try and remove it given that we have
> ntfs3 as a replacement. Worst case is we have to put it back in. Let's
> try it.
This patch breaks boot of my Lenovo ThinkPad X13s where I have an fstab
entry to access firmware from the original Windows partition; ended up
in some kind of systemd emergency mode.
Fix is easy enough once I figured out what broke, but requires changing
the fs type from 'ntfs' to 'ntfs3' in the fstab (after enabling NTFS3 in
the kernel config).
Is it possible to provide an alias or something to avoid breaking
people's machines like this? Perhaps something is needed for the Kconfig
too.
I also now get a bunch of warning when listing the root directory:
[ 68.967970] ntfs3: nvme0n1p3: ino=130d6, Correct links count -> 1.
[ 68.969137] ntfs3: nvme0n1p3: ino=13a, Correct links count -> 1.
[ 68.969798] ntfs3: nvme0n1p3: ino=3ad, Correct links count -> 1.
[ 68.970431] ntfs3: nvme0n1p3: ino=3d9, Correct links count -> 1.
[ 68.971150] ntfs3: nvme0n1p3: ino=26, Correct links count -> 1.
[ 68.971780] ntfs3: nvme0n1p3: ino=eb, Correct links count -> 1.
[ 68.972263] ntfs3: nvme0n1p3: ino=1ce, Correct links count -> 1.
[ 68.973062] ntfs3: nvme0n1p3: ino=a608, Correct links count -> 1.
Flagging this as a regression so that Thorsten is aware of it:
#regzbot introduced: 7ffa8f3d3023
Johan
next parent reply other threads:[~2024-03-22 16:35 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240115072025.2071931-1-willy@infradead.org>
[not found] ` <20240116-fernbedienung-vorwort-a21384fd7962@brauner>
2024-03-22 16:35 ` Johan Hovold [this message]
2024-03-25 8:28 ` [PATCH] fs: Remove NTFS classic Christian Brauner
2024-03-25 8:34 ` [PATCH 1/2] ntfs3: serve as alias for the legacy ntfs driver Christian Brauner
2024-03-25 10:09 ` Johan Hovold
2024-03-25 12:01 ` Christian Brauner
2024-03-25 8:34 ` [PATCH 2/2] ntfs3: remove warning Christian Brauner
2024-03-25 10:12 ` Johan Hovold
2024-03-25 12:05 ` Christian Brauner
2024-04-04 8:06 ` Linux regression tracking (Thorsten Leemhuis)
2024-04-11 11:03 ` Konstantin Komarov
2024-04-15 9:54 ` Johan Hovold
2024-04-15 10:20 ` Johan Hovold
2024-04-15 11:32 ` Anton Altaparmakov
2024-04-15 11:42 ` Johan Hovold
2024-04-15 14:15 ` Christian Brauner
2024-04-15 15:23 ` Linus Torvalds
2024-04-15 15:27 ` Matthew Wilcox
2024-04-15 15:47 ` Johan Hovold
2024-04-15 15:51 ` Linus Torvalds
2024-04-15 16:06 ` Johan Hovold
2024-04-16 10:38 ` Christian Brauner
2024-04-16 12:55 ` Johan Hovold
2024-04-17 16:07 ` Konstantin Komarov
2024-04-18 6:36 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zf2zPf5TO5oYt3I3@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=anton@tuxera.com \
--cc=brauner@kernel.org \
--cc=linkinjeon@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-ntfs-dev@lists.sourceforge.net \
--cc=ntfs3@lists.linux.dev \
--cc=regressions@lists.linux.dev \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).