From: Ard Biesheuvel <ardb@kernel.org>
To: Clayton Craft <clayton@craftyguy.net>
Cc: Hans de Goede <hdegoede@redhat.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
linux-efi@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
regressions@lists.linux.dev
Subject: Re: x86_64 32-bit EFI mixed mode boot broken
Date: Tue, 2 Apr 2024 09:25:10 +0300 [thread overview]
Message-ID: <CAMj1kXGDnYoz-rF+8JZoMfhGmGqL0PEdvSK8xWH8F4ELXiJB_Q@mail.gmail.com> (raw)
In-Reply-To: <20240401154436.GB26633@craftyguy.net>
On Tue, 2 Apr 2024 at 01:44, Clayton Craft <clayton@craftyguy.net> wrote:
>
> On Sun, 24 Mar 2024 22:53:47 +0200 Ard Biesheuvel <ardb@kernel.org> wrote:
> > > > Thanks.
> > > >
> > > > I pushed another branch
> > > >
> > > > https://git.kernel.org/pub/scm/linux/kernel/git/ardb/linux.git/log/?h=efi-clayton-3
> > > >
> > > > which has a proper fix for the issue that you found.
> > > >
> > > > As it turns out, the compat mixed mode (with handover protocol) was
> > > >
> > > > broken from the beginning, and the change you identified just happened
> > > >
> > > > to trigger it on your hardware.
> > >
> > >
> > > Tested and fixes booting on my Bay Trail tablet and NUC. Thanks for fixing this!
> > >
> > > Tested-by: Clayton Craft <clayton@craftyguy.net>
>
> So... maybe my testing wasn't as thorough as I thought, OR I am experiencing an
> unrelated problem. In any case, I'm having some difficulty figuring out what to
> blame. When using this patch on the 6.6 LTS:
>
> 1) kernel seems to panic right after displaying `disabling bootcon [efifb0]`. I
> determined that it's panicking by setting `panic=-1` and seeing it reboot after
> showing that message. I can work around it by setting `keep_bootcon`, but that's
> not ideal.
>
First of all, if you make it all the way to this point, it is unlikely
that this is the same issue. The issue that was fixed was preventing
the boot from proceeding past the very early 32-bit boot stage in the
decompressor, and by the time you hit this panic, the kernel is up an
running.
> 2) kernel complains about no root (from initrd). I can work around this by
> passing `initrd=my-initramfs` on the kernel cmdline.
>
So why is systemd-boot not passing this directly? AFAIK this is the
default method for systemd-boot, and I don't think it implements any
other methods.
> I haven't tried any newer kernels yet. The second issue above makes me wonder if
> your patch related to args might be to blame, but I'm not sure. Any help poking
> around further would be greatly appreciated :)
>
You might try this stable -rc
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/log/?h=linux-6.6.y
which should get released any day now. It has a couple of EFI related
fixes, although none of them seem related in particular.
Another thing you might try is to pass efi=noruntime to the boot, to
check whether EFI is implicated in this to begin with.
prev parent reply other threads:[~2024-04-02 6:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-21 22:05 x86_64 32-bit EFI mixed mode boot broken Clayton Craft
2024-03-21 22:48 ` Ard Biesheuvel
2024-03-22 0:06 ` Clayton Craft
2024-03-22 12:52 ` Ard Biesheuvel
2024-03-22 16:18 ` Clayton Craft
2024-03-22 16:51 ` Ard Biesheuvel
2024-03-22 17:57 ` Clayton Craft
2024-03-22 18:30 ` Ard Biesheuvel
2024-03-22 19:34 ` Clayton Craft
2024-03-23 12:39 ` Ard Biesheuvel
2024-03-23 17:18 ` Ard Biesheuvel
2024-03-24 5:53 ` Clayton Craft
2024-03-24 14:49 ` Hans de Goede
2024-03-24 17:43 ` Ard Biesheuvel
2024-03-24 20:45 ` Clayton Craft
2024-03-24 20:53 ` Ard Biesheuvel
2024-04-01 22:44 ` Clayton Craft
2024-04-02 6:25 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMj1kXGDnYoz-rF+8JZoMfhGmGqL0PEdvSK8xWH8F4ELXiJB_Q@mail.gmail.com \
--to=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=clayton@craftyguy.net \
--cc=dave.hansen@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=regressions@lists.linux.dev \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).