From: Enrik Berkhan <Enrik.Berkhan@inka.de>
To: Linux regressions mailing list <regressions@lists.linux.dev>,
David McFarland <corngood@gmail.com>,
Chris Feng <chris.feng@mediatek.com>
Cc: "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
"Alex Hung" <alexhung@gmail.com>,
"Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH 1/1] platform/x86/intel/hid: Don't wake on 5-button releases
Date: Mon, 01 Apr 2024 17:36:35 +0200 [thread overview]
Message-ID: <85837371eadac58dec812c0be14264152ee1e5fd.camel@inka.de> (raw)
In-Reply-To: <1198933e-bf89-4237-a6e8-f7daeeebf885@leemhuis.info>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
On Fri, 2024-03-29 at 14:51 +0100, Linux regression tracking (Thorsten
Leemhuis) wrote:
> [CCing Chris, who authored the culprit; also CCing the platform folks
> and a few lists]
(Intentionally replying to the "wrong" e-mail to get the enlarged
recipient list for free ...)
>
> Regarding the patch itself: hopefully this mail will get things
> moving.
>
> [1]
> https://lore.kernel.org/linux-pm/20240318191153.6978-1-corngood@gmail.com/
>
> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker'
> hat)
> --
> Everything you wanna know about Linux kernel regression tracking:
> https://linux-regtracking.leemhuis.info/about/#tldr
> If I did something stupid, please tell me, as explained on that page.
>
> #regzbot poke
>
> > Signed-off-by: David McFarland <corngood@gmail.com>
Tested-by: Enrik Berkhan <Enrik.Berkhan@inka.de>
> > > ---
> > drivers/platform/x86/intel/hid.c | 8 +++++++-
> > 1 file changed, 7 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/platform/x86/intel/hid.c
> > b/drivers/platform/x86/intel/hid.c
> > index 7457ca2b27a6..707de9895965 100644
> > --- a/drivers/platform/x86/intel/hid.c
> > +++ b/drivers/platform/x86/intel/hid.c
> > @@ -504,6 +504,7 @@ static void notify_handler(acpi_handle handle,
> > u32 event, void *context)
> > struct platform_device *device = context;
> > struct intel_hid_priv *priv = dev_get_drvdata(&device-
> > >dev);
> > unsigned long long ev_index;
> > + struct key_entry *ke;
> > int err;
> >
> > /*
> > @@ -545,11 +546,16 @@ static void notify_handler(acpi_handle
> > handle, u32 event, void *context)
> > if (event == 0xc0 || !priv->array)
> > return;
> >
> > - if (!sparse_keymap_entry_from_scancode(priv-
> > >array, event)) {
> > + ke = sparse_keymap_entry_from_scancode(priv-
> > >array, event);
> > +
> > + if (!ke) {
> > dev_info(&device->dev, "unknown event
> > 0x%x\n", event);
> > return;
> > }
> >
> > + if (ke->type == KE_IGNORE)
> > + return;
> > +
> > wakeup:
> > pm_wakeup_hard_event(&device->dev);
> >
-----BEGIN PGP SIGNATURE-----
iQGzBAEBCAAdFiEEbLyQBMI0qAWiF6l31AjqSkbLPKQFAmYK1IQACgkQ1AjqSkbL
PKSUXwv/YWiU334Osus+niffw9gN94vCQid6OWuTIbX2zMNIunHmpHouMtfo6dpb
7Qsyaz0sxaUEclRPLf/bSAV8zWromM/4Xoa/DoBq+GPOLle5wTJAlislhZVfDZFX
FZ0EfUg+MvThqlJD8yhGNJWGVnSn92hDid7yy5Y/BSWTPCNhRxEsqy+d0pN82EnD
0mqWnpfG28uqK6dtOLnvbiOuWQhgKYerKFYHXw8FLxZV0eKb3+RqBFf6ZdsAjUEC
+d7G9Oq4pc9jxZNvOMop+z3Eskd/bD8Wi2aDtR1qcRENMaK0ucevTuOjGL8Gh80c
SbgKu2eU/qVlbnVrcaPgpB0CXXza7SYUynw5XWB8jBWOj6w2nxpnQPm5a0Z5aNYw
/kLuabhSommEmUIJtoOA2vgO8D0ACfF2n95cNXaJRiOhuag3SRoair50TOzmf09Z
4uco5iaWeIQwEpVFGdy+qh0V18kYclnNMZHC9bhO6heBDLB9Wy/iXDxko9tMXm/v
XnfAKKw9
=udJV
-----END PGP SIGNATURE-----
prev parent reply other threads:[~2024-04-01 15:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240318191153.6978-1-corngood@gmail.com>
2024-03-21 9:31 ` [PATCH 0/1] Failure to hibernate on Dell Latitude 7430 Linux regression tracking (Thorsten Leemhuis)
[not found] ` <20240318191153.6978-2-corngood@gmail.com>
2024-03-29 13:51 ` [PATCH 1/1] platform/x86/intel/hid: Don't wake on 5-button releases Linux regression tracking (Thorsten Leemhuis)
2024-03-29 18:06 ` David McFarland
2024-03-30 6:54 ` Linux regression tracking (Thorsten Leemhuis)
2024-04-01 15:36 ` Enrik Berkhan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85837371eadac58dec812c0be14264152ee1e5fd.camel@inka.de \
--to=enrik.berkhan@inka.de \
--cc=alexhung@gmail.com \
--cc=chris.feng@mediatek.com \
--cc=corngood@gmail.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=regressions@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).