From: Leonard Lausen <leonard@lausen.nl>
To: nikita@trvn.ru, Lukasz Luba <lukasz.luba@arm.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Zhang Rui <rui.zhang@intel.com>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Nikita Travkin <nikitos.tr@gmail.com>,
regressions@lists.linux.dev
Subject: Re: [PATCH v2 0/3] gov_power_allocator: Allow binding before cooling devices
Date: Tue, 9 Apr 2024 10:42:44 -0400 [thread overview]
Message-ID: <594fdc5a-3b09-40df-98a0-43671665e55f@lausen.nl> (raw)
In-Reply-To: <20240403-gpa-no-cooling-devs-v2-0-79bdd8439449@trvn.ru>
Hi Nikita, Hi Łukasz,
thank you for fixing the e83747c2f8e3 ("thermal: gov_power_allocator: Set up trip points earlier") and 912e97c67cc3 ("thermal: gov_power_allocator: Move memory allocation out of throttle()") regressions as part of v6.9-rc3. As the regression was introduced in v6.8, would it be possible to include the fix in a v6.8 patch release?
Thank you
Leonard
(Resending with regressions@lists.linux.dev in CC)
#regzbot introduced: 912e97c67cc3f333c4c5df8f51498c651792e658
#regzbot fixed-by: 1057c4c36ef8b236a2e28edef301da0801338c5f
#regzbot introduced: e83747c2f8e3cc5e284e37a8921099f1901d79d8
#regzbot fixed-by: da781936e7c301e6197eb6513775748e79fb2575
On 4/3/24 07:31, Nikita Travkin via B4 Relay wrote:
> Recent changes in IPA made it fail probing if the TZ has no cooling
> devices attached on probe or no trip points defined.
>
> This series restores prior behavior to:
>
> - allow IPA to probe before cooling devices have attached;
> - allow IPA to probe when the TZ has no passive/active trip points.
>
> I've noticed that all thermal zones fail probing with -EINVAL on my
> sc7180 based Acer Aspire 1 since 6.8. This series allows me to bring
> them back.
>
> Additionally there is a commit that supresses the "sustainable_power
> will be estimated" warning on TZ that have no trip points (and thus IPA
> will not be able to do anything for them anyway). This allowed me to
> notice that some of the TZ with cooling_devices on my platform actually
> lack the sustainable_power value.
>
> Signed-off-by: Nikita Travkin <nikita@trvn.ru>
> ---
> Changes in v2:
> - Split to two changes (Lukasz)
> - Return 0 in allocate_actors_buffer() instead of suppressing -EINVAL
> (Lukasz)
> - Add a change to supress "sustainable_power will be estimated" warning
> on "empty" TZ
> - Link to v1: https://lore.kernel.org/r/20240321-gpa-no-cooling-devs-v1-1-5c9e0ef2062e@trvn.ru
>
> ---
> Nikita Travkin (3):
> thermal: gov_power_allocator: Allow binding without cooling devices
> thermal: gov_power_allocator: Allow binding without trip points
> thermal: gov_power_allocator: Suppress sustainable_power warning without trip_points
>
> drivers/thermal/gov_power_allocator.c | 16 ++++++----------
> 1 file changed, 6 insertions(+), 10 deletions(-)
> ---
> base-commit: 727900b675b749c40ba1f6669c7ae5eb7eb8e837
> change-id: 20240321-gpa-no-cooling-devs-c79ee3288325
>
> Best regards,
next parent reply other threads:[~2024-04-09 14:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240403-gpa-no-cooling-devs-v2-0-79bdd8439449@trvn.ru>
2024-04-09 14:42 ` Leonard Lausen [this message]
2024-04-09 14:46 ` [PATCH v2 0/3] gov_power_allocator: Allow binding before cooling devices Nikita Travkin
2024-04-11 6:38 ` Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=594fdc5a-3b09-40df-98a0-43671665e55f@lausen.nl \
--to=leonard@lausen.nl \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=nikita@trvn.ru \
--cc=nikitos.tr@gmail.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=regressions@lists.linux.dev \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).