From: "Paul E. McKenney" <paulmck@kernel.org>
To: Boqun Feng <boqun.feng@gmail.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
rcu@vger.kernel.org, linux-kernel@vger.kernel.org,
Frederic Weisbecker <frederic@kernel.org>,
Josh Triplett <josh@joshtriplett.org>,
Peter Zijlstra <peterz@infradead.org>,
Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH v2] rcu: mollify sparse with RCU guard
Date: Tue, 26 Mar 2024 10:21:40 -0700 [thread overview]
Message-ID: <df1ecb31-fed2-4069-93bf-8773f30842b2@paulmck-laptop> (raw)
In-Reply-To: <ZgG3UC-x8wAIOdd3@boqun-archlinux>
On Mon, Mar 25, 2024 at 10:41:36AM -0700, Boqun Feng wrote:
> On Mon, Mar 25, 2024 at 06:39:08PM +0100, Johannes Berg wrote:
> > From: Johannes Berg <johannes.berg@intel.com>
> >
> > When using "guard(rcu)();" sparse will complain, because even
> > though it now understands the cleanup attribute, it doesn't
> > evaluate the calls from it at function exit, and thus doesn't
> > count the context correctly.
> >
> > Given that there's a conditional in the resulting code:
> >
> > static inline void class_rcu_destructor(class_rcu_t *_T)
> > {
> > if (_T->lock) {
> > rcu_read_unlock();
> > }
> > }
> >
> > it seems that even trying to teach sparse to evalulate the
> > cleanup attribute function it'd still be difficult to really
> > make it understand the full context here.
> >
> > Suppress the sparse warning by just releasing the context in
> > the acquisition part of the function, after all we know it's
> > safe with the guard, that's the whole point of it.
> >
> > Signed-off-by: Johannes Berg <johannes.berg@intel.com>
>
> Reviewed-by: Boqun Feng <boqun.feng@gmail.com>
Queued, thank you both!
Thanx, Paul
> Regards,
> Boqun
>
> > ---
> > v2: add a comment after discussion with Boqun
> >
> > ---
> > include/linux/rcupdate.h | 14 +++++++++++++-
> > 1 file changed, 13 insertions(+), 1 deletion(-)
> >
> > diff --git a/include/linux/rcupdate.h b/include/linux/rcupdate.h
> > index 0746b1b0b663..6a3c52b3c180 100644
> > --- a/include/linux/rcupdate.h
> > +++ b/include/linux/rcupdate.h
> > @@ -1059,6 +1059,18 @@ rcu_head_after_call_rcu(struct rcu_head *rhp, rcu_callback_t f)
> > extern int rcu_expedited;
> > extern int rcu_normal;
> >
> > -DEFINE_LOCK_GUARD_0(rcu, rcu_read_lock(), rcu_read_unlock())
> > +DEFINE_LOCK_GUARD_0(rcu,
> > + do {
> > + rcu_read_lock();
> > + /*
> > + * sparse doesn't call the cleanup function,
> > + * so just release immediately and don't track
> > + * the context. We don't need to anyway, since
> > + * the whole point of the guard is to not need
> > + * the explicit unlock.
> > + */
> > + __release(RCU);
> > + } while(0),
> > + rcu_read_unlock())
> >
> > #endif /* __LINUX_RCUPDATE_H */
> > --
> > 2.44.0
> >
prev parent reply other threads:[~2024-03-26 17:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 17:39 [PATCH v2] rcu: mollify sparse with RCU guard Johannes Berg
2024-03-25 17:41 ` Boqun Feng
2024-03-26 17:21 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df1ecb31-fed2-4069-93bf-8773f30842b2@paulmck-laptop \
--to=paulmck@kernel.org \
--cc=boqun.feng@gmail.com \
--cc=frederic@kernel.org \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rcu@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).