From: John Johansen <john.johansen@canonical.com>
To: Peter Zijlstra <peterz@infradead.org>,
torvalds@linux-foundation.org, keescook@chromium.org,
gregkh@linuxfoundation.org, pbonzini@redhat.com
Cc: masahiroy@kernel.org, nathan@kernel.org, ndesaulniers@google.com,
nicolas@fjasle.eu, catalin.marinas@arm.com, will@kernel.org,
vkoul@kernel.org, trix@redhat.com, ojeda@kernel.org,
mingo@redhat.com, longman@redhat.com, boqun.feng@gmail.com,
dennis@kernel.org, tj@kernel.org, cl@linux.com, acme@kernel.org,
mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
jolsa@kernel.org, namhyung@kernel.org, irogers@google.com,
adrian.hunter@intel.com, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
bristot@redhat.com, vschneid@redhat.com, paulmck@kernel.org,
frederic@kernel.org, quic_neeraju@quicinc.com,
joel@joelfernandes.org, josh@joshtriplett.org,
mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com,
rientjes@google.com, vbabka@suse.cz, roman.gushchin@linux.dev,
42.hyeyoo@gmail.com, apw@canonical.com, joe@perches.com,
dwaipayanray1@gmail.com, lukas.bulwahn@gmail.com,
paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
dmaengine@vger.kernel.org, llvm@lists.linux.dev,
linux-perf-users@vger.kernel.org, rcu@vger.kernel.org,
linux-security-module@vger.kernel.org, tglx@linutronix.de,
ravi.bangoria@amd.com, error27@gmail.com,
luc.vanoostenryck@gmail.com
Subject: Re: [PATCH v3 02/57] apparmor: Free up __cleanup() name
Date: Tue, 16 Jan 2024 10:10:03 -0800 [thread overview]
Message-ID: <b26f06ee-9617-4ba2-aa4e-b431407acd7a@canonical.com> (raw)
In-Reply-To: <20230612093537.536441207@infradead.org>
On 6/12/23 02:07, Peter Zijlstra wrote:
> In order to use __cleanup for __attribute__((__cleanup__(func))) the
> name must not be used for anything else. Avoid the conflict.
>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: John Johansen <john.johansen@canonical.com>
> ---
> security/apparmor/include/lib.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> --- a/security/apparmor/include/lib.h
> +++ b/security/apparmor/include/lib.h
> @@ -232,7 +232,7 @@ void aa_policy_destroy(struct aa_policy
> */
> #define fn_label_build(L, P, GFP, FN) \
> ({ \
> - __label__ __cleanup, __done; \
> + __label__ __do_cleanup, __done; \
> struct aa_label *__new_; \
> \
> if ((L)->size > 1) { \
> @@ -250,7 +250,7 @@ void aa_policy_destroy(struct aa_policy
> __new_ = (FN); \
> AA_BUG(!__new_); \
> if (IS_ERR(__new_)) \
> - goto __cleanup; \
> + goto __do_cleanup; \
> __lvec[__j++] = __new_; \
> } \
> for (__j = __count = 0; __j < (L)->size; __j++) \
> @@ -272,7 +272,7 @@ void aa_policy_destroy(struct aa_policy
> vec_cleanup(profile, __pvec, __count); \
> } else \
> __new_ = NULL; \
> -__cleanup: \
> +__do_cleanup: \
> vec_cleanup(label, __lvec, (L)->size); \
> } else { \
> (P) = labels_profile(L); \
>
>
next prev parent reply other threads:[~2024-01-16 18:10 UTC|newest]
Thread overview: 103+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-12 9:07 [PATCH v3 00/57] Scope-based Resource Management Peter Zijlstra
2023-06-12 9:07 ` [PATCH v3 01/57] dmaengine: ioat: Free up __cleanup() name Peter Zijlstra
2023-06-16 22:41 ` Dave Jiang
2023-06-12 9:07 ` [PATCH v3 02/57] apparmor: " Peter Zijlstra
2023-06-13 8:38 ` John Johansen
2023-06-13 10:28 ` John Johansen
2024-01-16 18:10 ` John Johansen [this message]
2023-06-12 9:07 ` [PATCH v3 03/57] locking: Introduce __cleanup() based infrastructure Peter Zijlstra
2023-06-13 10:55 ` Peter Zijlstra
2023-06-13 19:46 ` Kees Cook
2023-06-13 17:16 ` Miguel Ojeda
2023-08-14 7:24 ` Bartosz Golaszewski
2024-01-14 6:49 ` Dmitry Torokhov
2023-06-12 9:07 ` [PATCH v3 04/57] kbuild: Drop -Wdeclaration-after-statement Peter Zijlstra
2023-06-14 6:13 ` Masahiro Yamada
2023-06-14 8:25 ` Peter Zijlstra
2023-06-12 9:07 ` [PATCH v3 05/57] sched: Simplify get_nohz_timer_target() Peter Zijlstra
2023-06-12 9:07 ` [PATCH v3 06/57] sched: Simplify sysctl_sched_uclamp_handler() Peter Zijlstra
2023-06-12 13:47 ` Dan Carpenter
2023-06-12 9:07 ` [PATCH v3 07/57] sched: Simplify: migrate_swap_stop() Peter Zijlstra
2023-06-12 9:07 ` [PATCH v3 08/57] sched: Simplify wake_up_if_idle() Peter Zijlstra
2023-06-12 18:02 ` Boqun Feng
2023-06-12 20:02 ` Peter Zijlstra
2023-06-12 9:07 ` [PATCH v3 09/57] sched: Simplify ttwu() Peter Zijlstra
2023-06-12 13:51 ` Dan Carpenter
2023-06-12 14:08 ` Peter Zijlstra
2023-06-12 9:07 ` [PATCH v3 10/57] sched: Simplify sched_exec() Peter Zijlstra
2023-06-12 9:07 ` [PATCH v3 11/57] sched: Simplify sched_tick_remote() Peter Zijlstra
2023-06-12 9:07 ` [PATCH v3 12/57] sched: Simplify try_steal_cookie() Peter Zijlstra
2023-06-12 9:07 ` [PATCH v3 13/57] sched: Simplify sched_core_cpu_{starting,deactivate}() Peter Zijlstra
2023-06-12 9:07 ` [PATCH v3 14/57] sched: Simplify set_user_nice() Peter Zijlstra
2023-06-12 9:07 ` [PATCH v3 15/57] sched: Simplify syscalls Peter Zijlstra
2023-06-12 9:07 ` [PATCH v3 16/57] sched: Simplify sched_{set,get}affinity() Peter Zijlstra
2023-06-12 9:07 ` [PATCH v3 17/57] sched: Simplify yield_to() Peter Zijlstra
2023-06-12 9:07 ` [PATCH v3 18/57] sched: Simplify sched_rr_get_interval() Peter Zijlstra
2023-06-12 9:07 ` [PATCH v3 19/57] sched: Simplify sched_move_task() Peter Zijlstra
2023-06-12 9:07 ` [PATCH v3 20/57] sched: Simplify tg_set_cfs_bandwidth() Peter Zijlstra
2023-06-12 9:07 ` [PATCH v3 21/57] sched: Misc cleanups Peter Zijlstra
2023-06-12 9:07 ` [PATCH v3 22/57] perf: Fix cpuctx refcounting Peter Zijlstra
2023-06-12 9:07 ` [PATCH v3 23/57] perf: Simplify perf_event_alloc() error path Peter Zijlstra
2023-06-12 9:07 ` [PATCH v3 24/57] perf: Simplify perf_pmu_register() " Peter Zijlstra
2023-06-12 9:07 ` [PATCH v3 25/57] perf: Simplify perf_fget_light() Peter Zijlstra
2023-06-12 9:07 ` [PATCH v3 26/57] perf: Simplify event_function*() Peter Zijlstra
2023-06-12 14:46 ` Dan Carpenter
2023-06-12 14:58 ` Peter Zijlstra
2023-06-13 5:56 ` Namhyung Kim
2023-06-13 7:39 ` Peter Zijlstra
2023-06-12 9:07 ` [PATCH v3 27/57] perf: Simplify perf_cgroup_connect() Peter Zijlstra
2023-06-12 9:07 ` [PATCH v3 28/57] perf; Simplify event_sched_in() Peter Zijlstra
2023-06-13 19:43 ` Kees Cook
2023-06-12 9:07 ` [PATCH v3 29/57] perf: Simplify: __perf_install_in_context() Peter Zijlstra
2023-06-12 9:07 ` [PATCH v3 30/57] perf: Simplify: *perf_event_{dis,en}able*() Peter Zijlstra
2023-06-12 9:07 ` [PATCH v3 31/57] perf: Simplify perf_event_modify_attr() Peter Zijlstra
2023-06-12 9:07 ` [PATCH v3 32/57] perf: Simplify perf_event_context_sched_in() Peter Zijlstra
2023-06-12 9:07 ` [PATCH v3 33/57] perf: Simplify perf_adjust_freq_unthr_context() Peter Zijlstra
2023-06-12 16:27 ` Linus Torvalds
2023-06-12 18:44 ` Peter Zijlstra
2023-06-12 18:55 ` Linus Torvalds
2023-06-12 20:05 ` Peter Zijlstra
2023-06-13 12:05 ` Peter Zijlstra
2023-06-12 9:07 ` [PATCH v3 34/57] perf: Simplify perf_event_*_on_exec() Peter Zijlstra
2023-06-12 9:07 ` [PATCH v3 35/57] perf: Simplify *perf_event_read*() Peter Zijlstra
2023-06-12 9:07 ` [PATCH v3 36/57] perf: Simplify find_get_pmu_context() Peter Zijlstra
2023-06-12 9:07 ` [PATCH v3 37/57] perf: Simplify perf_read_group() Peter Zijlstra
2023-06-12 9:07 ` [PATCH v3 38/57] perf: Simplify IOC_SET_OUTPUT Peter Zijlstra
2023-06-12 9:07 ` [PATCH v3 39/57] perf: Simplify perf_event_*_userpage() Peter Zijlstra
2023-06-12 9:07 ` [PATCH v3 40/57] perf: Simplify perf_mmap_close()/perf_aux_sample_output() Peter Zijlstra
2023-06-12 9:07 ` [PATCH v3 41/57] perf: Simplify __perf_event_output() Peter Zijlstra
2023-06-12 9:07 ` [PATCH v3 42/57] perf: Simplify perf_iterate_sb() Peter Zijlstra
2023-06-12 9:07 ` [PATCH v3 43/57] perf: Simplify perf_sw_event() Peter Zijlstra
2023-06-12 9:07 ` [PATCH v3 44/57] perf: Simplify bpf_overflow_handler() Peter Zijlstra
2023-06-12 9:07 ` [PATCH v3 45/57] perf: Simplify perf_event_parse_addr_filter() Peter Zijlstra
2023-06-13 19:47 ` Kees Cook
2023-06-12 9:07 ` [PATCH v3 46/57] perf: Simplify pmu_dev_alloc() Peter Zijlstra
2023-06-12 9:44 ` Peter Zijlstra
2023-06-12 9:55 ` Greg KH
2023-06-12 12:18 ` Greg KH
2023-06-12 12:29 ` Paolo Bonzini
2023-06-12 12:58 ` Greg KH
2023-06-12 13:09 ` Greg KH
2023-06-12 13:35 ` Greg KH
2023-06-12 14:13 ` Peter Zijlstra
2023-06-12 15:44 ` Greg KH
2023-06-13 7:34 ` Peter Zijlstra
2023-06-13 7:50 ` Greg KH
2023-06-13 10:50 ` Peter Zijlstra
2023-06-12 9:08 ` [PATCH v3 47/57] perf: Simplify perf_pmu_register() Peter Zijlstra
2023-06-12 9:08 ` [PATCH v3 48/57] perf: Simplify perf_init_event() Peter Zijlstra
2023-06-12 9:08 ` [PATCH v3 49/57] perf: Simplify perf_event_alloc() Peter Zijlstra
2023-06-12 9:08 ` [PATCH v3 50/57] perf: Simplify sys_perf_event_open() Peter Zijlstra
2023-06-12 9:08 ` [PATCH v3 51/57] perf: Simplify perf_event_create_kernel_counter() Peter Zijlstra
2023-06-12 9:08 ` [PATCH v3 52/57] perf: Simplify perf_event_init_context() Peter Zijlstra
2023-06-12 9:08 ` [PATCH v3 53/57] perf: Simplify perf_event_sysfs_init() Peter Zijlstra
2023-06-12 9:08 ` [PATCH v3 54/57] perf: Misc cleanups Peter Zijlstra
2023-06-12 9:08 ` [PATCH v3 55/57] perf: Simplify find_get_context() Peter Zijlstra
2023-06-12 9:08 ` [PATCH v3 56/57] perf: Simplify perf_pmu_output_stop() Peter Zijlstra
2023-06-12 16:19 ` Linus Torvalds
2023-06-12 17:11 ` Sean Christopherson
2023-06-12 17:43 ` Linus Torvalds
2023-06-12 18:55 ` Peter Zijlstra
2023-06-12 9:08 ` [PATCH v3 57/57] perf: Simplify perf_install_in_context() Peter Zijlstra
2023-06-12 9:51 ` [PATCH v3 00/57] Scope-based Resource Management Peter Zijlstra
2023-06-12 16:37 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b26f06ee-9617-4ba2-aa4e-b431407acd7a@canonical.com \
--to=john.johansen@canonical.com \
--cc=42.hyeyoo@gmail.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=apw@canonical.com \
--cc=boqun.feng@gmail.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=catalin.marinas@arm.com \
--cc=cl@linux.com \
--cc=dennis@kernel.org \
--cc=dietmar.eggemann@arm.com \
--cc=dmaengine@vger.kernel.org \
--cc=dwaipayanray1@gmail.com \
--cc=error27@gmail.com \
--cc=frederic@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=irogers@google.com \
--cc=jiangshanlai@gmail.com \
--cc=jmorris@namei.org \
--cc=joe@perches.com \
--cc=joel@joelfernandes.org \
--cc=jolsa@kernel.org \
--cc=josh@joshtriplett.org \
--cc=juri.lelli@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=longman@redhat.com \
--cc=luc.vanoostenryck@gmail.com \
--cc=lukas.bulwahn@gmail.com \
--cc=mark.rutland@arm.com \
--cc=masahiroy@kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=nicolas@fjasle.eu \
--cc=ojeda@kernel.org \
--cc=paul@paul-moore.com \
--cc=paulmck@kernel.org \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=quic_neeraju@quicinc.com \
--cc=ravi.bangoria@amd.com \
--cc=rcu@vger.kernel.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=rostedt@goodmis.org \
--cc=serge@hallyn.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=trix@redhat.com \
--cc=vbabka@suse.cz \
--cc=vincent.guittot@linaro.org \
--cc=vkoul@kernel.org \
--cc=vschneid@redhat.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).