From: "Paul E. McKenney" <paulmck@kernel.org>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Onkarnarth <onkarnath.1@samsung.com>,
frederic@kernel.org, quic_neeraju@quicinc.com,
joel@joelfernandes.org, josh@joshtriplett.org,
boqun.feng@gmail.com, rostedt@goodmis.org,
mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com,
qiang.zhang1211@gmail.com, rcu@vger.kernel.org,
linux-kernel@vger.kernel.org, r.thapliyal@samsung.com,
maninder1.s@samsung.com, tj@kernel.org, peterz@infradead.org
Subject: Re: [PATCH 1/1] rcu/sync: remove un-used rcu_sync_enter_start function
Date: Tue, 16 Jan 2024 11:10:14 -0800 [thread overview]
Message-ID: <75830847-a2ab-4bf4-bd4c-f7695e48ea3d@paulmck-laptop> (raw)
In-Reply-To: <20240116181058.GB12342@redhat.com>
On Tue, Jan 16, 2024 at 07:10:59PM +0100, Oleg Nesterov wrote:
> On 01/16, Paul E. McKenney wrote:
> >
> > On Thu, Jan 11, 2024 at 02:57:22PM +0530, Onkarnarth wrote:
> > > From: Onkarnath <onkarnath.1@samsung.com>
> > >
> > > With commit '6a010a49b63a ("cgroup: Make !percpu threadgroup_rwsem
> > > operations optional")' usage of rcu_sync_enter_start is removed.
> > >
> > > So this function can also be removed.
> > >
> > > Signed-off-by: Onkarnath <onkarnath.1@samsung.com>
> > > Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
>
> Acked-by: Oleg Nesterov <oleg@redhat.com>
Queued, thank you all!
> For the record, this was already discussed, see
> https://lore.kernel.org/all/20220725121208.GB28662@redhat.com/
I am clearly not keeping up. ;-)
> Note also the patch in this message, __rcu_sync_enter(wait => false)
> is a better alternative if someone needs rcu_sync_enter_start() again.
Good to know! I added this to the commit log, so please let me know
if this is in any way inappropriate:
------------------------------------------------------------------------
In the words of Oleg Nesterov:
__rcu_sync_enter(wait => false) is a better alternative if
someone needs rcu_sync_enter_start() again.
Link: https://lore.kernel.org/all/20220725121208.GB28662@redhat.com/
------------------------------------------------------------------------
> This patch probably makes sense anyway. Not only cgroup_favor_dynmods()
> can use __rcu_sync_enter(), freeze_super() can use it too to avoid
> 3 synchronize_rcu()'s in a row.
Thank you for the background information, much appreciated!
Thanx, Paul
next prev parent reply other threads:[~2024-01-16 19:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240111092805epcas5p2ebb993010ae31d039e8f9de1e7818f7c@epcas5p2.samsung.com>
2024-01-11 9:27 ` [PATCH 1/1] rcu/sync: remove un-used rcu_sync_enter_start function Onkarnarth
2024-01-16 16:50 ` Paul E. McKenney
2024-01-16 18:10 ` Oleg Nesterov
2024-01-16 19:10 ` Paul E. McKenney [this message]
2024-01-16 18:14 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75830847-a2ab-4bf4-bd4c-f7695e48ea3d@paulmck-laptop \
--to=paulmck@kernel.org \
--cc=boqun.feng@gmail.com \
--cc=frederic@kernel.org \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maninder1.s@samsung.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=oleg@redhat.com \
--cc=onkarnath.1@samsung.com \
--cc=peterz@infradead.org \
--cc=qiang.zhang1211@gmail.com \
--cc=quic_neeraju@quicinc.com \
--cc=r.thapliyal@samsung.com \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).