From: Dan Carpenter <dan.carpenter@linaro.org>
To: "Paul E. McKenney" <paulmck@kernel.org>
Cc: dwmw@amazon.co.uk, rcu@vger.kernel.org
Subject: Re: [bug report] rcu: Kill rnp->ofl_seq and use only rcu_state.ofl_lock for exclusion
Date: Thu, 9 May 2024 09:46:44 +0300 [thread overview]
Message-ID: <2978272c-1054-4f33-a31a-8cece512cc55@moroto.mountain> (raw)
In-Reply-To: <c18678f2-dff9-4d2b-9079-d77ab276ccf2@paulmck-laptop>
On Wed, May 08, 2024 at 04:50:46PM -0700, Paul E. McKenney wrote:
> On Wed, May 08, 2024 at 08:38:06PM +0300, Dan Carpenter wrote:
> > On Wed, May 08, 2024 at 10:32:43AM -0700, Paul E. McKenney wrote:
> > >
> > > Agreed, and please see below for the proposed cleanup in this case.
> > >
> > > Thanx, Paul
> >
> > Thanks! Did you see the other warning I mentioned?
> >
> > kernel/rcu/srcutree.c:910 srcu_gp_end()
> > warn: mixing irq and irqsave
>
> I did, but then I promptly forgot about it. Thank you for the reminder.
>
> > Btw, I'm mostly sending you these because I know you're interested in
> > these sorts of cleanups. I didn't bother sending one to aacraid people,
> > for example. :P
>
> Maintainer's choice! ;-)
>
> How about the following?
>
Thanks!
regards,
dan carpenter
prev parent reply other threads:[~2024-05-09 6:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 12:29 [bug report] rcu: Kill rnp->ofl_seq and use only rcu_state.ofl_lock for exclusion Dan Carpenter
2024-05-08 14:33 ` Paul E. McKenney
2024-05-08 14:55 ` Dan Carpenter
2024-05-08 17:32 ` Paul E. McKenney
2024-05-08 17:38 ` Dan Carpenter
2024-05-08 23:50 ` Paul E. McKenney
2024-05-09 6:46 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2978272c-1054-4f33-a31a-8cece512cc55@moroto.mountain \
--to=dan.carpenter@linaro.org \
--cc=dwmw@amazon.co.uk \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).