From: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
To: David Young <dyoung-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>,
radiotap-S783fYmB3Ccdnm+yROfE0A@public.gmane.org
Subject: Re: [RFA] TLV fields for radiotap
Date: Tue, 09 Apr 2019 10:38:37 +0200 [thread overview]
Message-ID: <a6ec00b90901fba1264c8943003a25786a595d6d.camel@sipsolutions.net> (raw)
In-Reply-To: <2c771c875d88d51d1cd98023686f084a5b6486bc.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
On Tue, 2018-12-18 at 14:45 +0100, Johannes Berg wrote:
> > I had a thought about this tonight: maybe the solution is to define
> > a new radiotap field, "hint," that contains a hint about the offset
> > to a field. The field begins with a 16-bit (?) field number, f, to
> > be interpreted in the current namespace. Following that is a 16-bit
> > (?) absolute offset from the end of the hint field to field f. If you
> > introduce your vendor namespace when the last-assigned presence bit is
> > bit p, and later you reuse the vendor namespace with newly-assigned
> > presence bit p+k, then you can supply a hint for the vendor namespace
> > field so that old readers can still benefit from presence bits 0..p and
> > your vendor fields.
I thought about this again ... and I decided I still don't think it's a
good idea.
> Hmm. Actually, yes, I think that would work. However, it's hard to guess
> which fields the parser can do, so unless you have a really smart parser
> you'd end up with
>
> fields 0..n, hint, n+1, hint, n+2, hint, n+3, vendor_data
I think this one's the killer to me, in a sense.
If you think about it - yes, right now, you could say
Implementations currently understand fields 0..HE-MU, and I want to
have some new field (e.g. S1G) and will add a hint.
With this thinking, you get:
0..HE-MU, vendor-data-hint, S1G, vendor-data
But like I described above, the next time you do this you probably don't
want to change it to be
0..HE-MU, S1G, vendor-data-hint, EHT, vendor-data
but rather
0..HE-MU, vendor-data-hint, S1G, vendor-data-hint, EHT, vendor-data
and that gets complex really fast, and also *bigger* than any sort of
TLV formatting would ever get.
I'll resend the adoption proposal now, I think it's the better solution.
johannes
next prev parent reply other threads:[~2019-04-09 8:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 8:47 [RFA] TLV fields for radiotap Johannes Berg
[not found] ` <1531126034.3298.18.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2018-09-04 12:14 ` Johannes Berg
[not found] ` <1536063298.3940.12.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2018-11-20 20:09 ` Johannes Berg
[not found] ` <81658b7a400e6189c55587c8276d5555b6fe37f0.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2018-12-18 2:05 ` David Young
[not found] ` <20181218020526.GH27633-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
2018-12-18 13:45 ` Johannes Berg
[not found] ` <2c771c875d88d51d1cd98023686f084a5b6486bc.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2019-04-09 8:38 ` Johannes Berg [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-04-09 8:51 Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6ec00b90901fba1264c8943003a25786a595d6d.camel@sipsolutions.net \
--to=johannes-cdvu00un1vgdhxzaddlk8q@public.gmane.org \
--cc=dyoung-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org \
--cc=radiotap-S783fYmB3Ccdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).