From: Hongren Zheng <i@zenithal.me>
To: Yangyu Chen <cyy@cyyself.name>
Cc: qemu-riscv@nongnu.org, qemu-devel@nongnu.org,
Palmer Dabbelt <palmer@dabbelt.com>,
Alistair Francis <alistair.francis@wdc.com>,
Bin Meng <bmeng.cn@gmail.com>, Weiwei Li <liwei1518@gmail.com>,
Daniel Henrique Barboza <dbarboza@ventanamicro.com>,
Liu Zhiwei <zhiwei_liu@linux.alibaba.com>,
Max Chou <max.chou@sifive.com>,
qemu-stable@nongnu.org
Subject: Re: [PATCH RESEND] target/riscv/cpu.c: fix Zvkb extension config
Date: Thu, 16 May 2024 22:01:59 +0800 [thread overview]
Message-ID: <ZkYR1_ZyjR8f5Yt0@Sun> (raw)
In-Reply-To: <tencent_8C6C872035C2F071090E689F3ADAE1E2C50A@qq.com>
On Mon, May 13, 2024 at 03:18:53PM +0800, Yangyu Chen wrote:
> I think this patch also needs to back-port to stable-8.2.
Indeed, downstream OpenSSL CI using Ubuntu 24.04, which ships
QEMU 8.2.2, encountered this bug and that is quite confusing
QEMU 9.0.0 is also affected
Links
https://github.com/openssl/openssl/pull/24403/commits/5f7750fa0d366fd87d3280c18f7539f720a8d0be
https://github.com/openssl/openssl/pull/24403#issuecomment-2115320298
>
> I added qemu-stable@nongnu.org to cc.
>
> > On May 11, 2024, at 19:26, Yangyu Chen <cyy@cyyself.name> wrote:
> >
> > This code has a typo that writes zvkb to zvkg, causing users can't
> > enable zvkb through the config. This patch gets this fixed.
> >
> > Signed-off-by: Yangyu Chen <cyy@cyyself.name>
> > Fixes: ea61ef7097d0 ("target/riscv: Move vector crypto extensions to riscv_cpu_extensions")
> > Reviewed-by: LIU Zhiwei <zhiwei_liu@linux.alibaba.com>
> > ---
> > target/riscv/cpu.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
> > index eb1a2e7d6d..13cd34adbd 100644
> > --- a/target/riscv/cpu.c
> > +++ b/target/riscv/cpu.c
> > @@ -1535,7 +1535,7 @@ const RISCVCPUMultiExtConfig riscv_cpu_extensions[] = {
> > /* Vector cryptography extensions */
> > MULTI_EXT_CFG_BOOL("zvbb", ext_zvbb, false),
> > MULTI_EXT_CFG_BOOL("zvbc", ext_zvbc, false),
> > - MULTI_EXT_CFG_BOOL("zvkb", ext_zvkg, false),
> > + MULTI_EXT_CFG_BOOL("zvkb", ext_zvkb, false),
> > MULTI_EXT_CFG_BOOL("zvkg", ext_zvkg, false),
> > MULTI_EXT_CFG_BOOL("zvkned", ext_zvkned, false),
> > MULTI_EXT_CFG_BOOL("zvknha", ext_zvknha, false),
> > --
> > 2.43.0
> >
>
>
>
next prev parent reply other threads:[~2024-05-16 14:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-11 11:26 [PATCH RESEND] target/riscv/cpu.c: fix Zvkb extension config Yangyu Chen
2024-05-11 13:54 ` liwei
2024-05-11 17:16 ` Max Chou
2024-05-11 17:58 ` Yangyu Chen
2024-05-13 2:57 ` Alistair Francis
2024-05-13 3:29 ` Alistair Francis
2024-05-13 7:18 ` Yangyu Chen
2024-05-16 14:01 ` Hongren Zheng [this message]
2024-05-13 12:21 ` Daniel Henrique Barboza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZkYR1_ZyjR8f5Yt0@Sun \
--to=i@zenithal.me \
--cc=alistair.francis@wdc.com \
--cc=bmeng.cn@gmail.com \
--cc=cyy@cyyself.name \
--cc=dbarboza@ventanamicro.com \
--cc=liwei1518@gmail.com \
--cc=max.chou@sifive.com \
--cc=palmer@dabbelt.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).