From: Alistair Francis <alistair23@gmail.com>
To: Cheng Yang <yangcheng.work@foxmail.com>
Cc: qemu-riscv@nongnu.org, Palmer Dabbelt <palmer@dabbelt.com>,
Alistair Francis <alistair.francis@wdc.com>,
Bin Meng <bin.meng@windriver.com>,
Weiwei Li <liwei1518@gmail.com>,
Daniel Henrique Barboza <dbarboza@ventanamicro.com>,
Liu Zhiwei <zhiwei_liu@linux.alibaba.com>,
"open list:All patches CC here" <qemu-devel@nongnu.org>
Subject: Re: [PATCH v1 1/1] hw/riscv/boot.c: Support 64-bit address for initrd
Date: Mon, 29 Apr 2024 12:26:57 +1000 [thread overview]
Message-ID: <CAKmqyKPQRR7oDiMyz6BA8ssTU43Df_G-7Acq1tmkuwhjBtxOVA@mail.gmail.com> (raw)
In-Reply-To: <tencent_A4482251DD0890F312758FA6B33F60815609@qq.com>
On Mon, Apr 1, 2024 at 10:44 PM Cheng Yang <yangcheng.work@foxmail.com> wrote:
>
> Use qemu_fdt_setprop_u64() instead of qemu_fdt_setprop_cell()
> to set the address of initrd in FDT to support 64-bit address.
>
> Signed-off-by: Cheng Yang <yangcheng.work@foxmail.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> hw/riscv/boot.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c
> index 09878e722c..47281ca853 100644
> --- a/hw/riscv/boot.c
> +++ b/hw/riscv/boot.c
> @@ -209,8 +209,8 @@ static void riscv_load_initrd(MachineState *machine, uint64_t kernel_entry)
> /* Some RISC-V machines (e.g. opentitan) don't have a fdt. */
> if (fdt) {
> end = start + size;
> - qemu_fdt_setprop_cell(fdt, "/chosen", "linux,initrd-start", start);
> - qemu_fdt_setprop_cell(fdt, "/chosen", "linux,initrd-end", end);
> + qemu_fdt_setprop_u64(fdt, "/chosen", "linux,initrd-start", start);
> + qemu_fdt_setprop_u64(fdt, "/chosen", "linux,initrd-end", end);
> }
> }
>
> --
> 2.34.1
>
>
prev parent reply other threads:[~2024-04-29 2:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-01 7:51 [PATCH v1 1/1] hw/riscv/boot.c: Support 64-bit address for initrd Cheng Yang
2024-04-29 2:26 ` Alistair Francis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKmqyKPQRR7oDiMyz6BA8ssTU43Df_G-7Acq1tmkuwhjBtxOVA@mail.gmail.com \
--to=alistair23@gmail.com \
--cc=alistair.francis@wdc.com \
--cc=bin.meng@windriver.com \
--cc=dbarboza@ventanamicro.com \
--cc=liwei1518@gmail.com \
--cc=palmer@dabbelt.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=yangcheng.work@foxmail.com \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).