From: Akihiko Odaki <akihiko.odaki@daynix.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: "Jason Wang" <jasowang@redhat.com>,
"Dmitry Fleytman" <dmitry.fleytman@gmail.com>,
"Sriram Yagnaraman" <sriram.yagnaraman@ericsson.com>,
"Luigi Rizzo" <rizzo@iet.unipi.it>,
"Giuseppe Lettieri" <g.lettieri@iet.unipi.it>,
"Vincenzo Maffione" <v.maffione@gmail.com>,
"Andrew Melnychenko" <andrew@daynix.com>,
"Yuri Benditovich" <yuri.benditovich@daynix.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
qemu-devel@nongnu.org,
20240428-rss-v10-0-73cbaa91aeb6@daynix.com
Subject: Re: [PATCH 0/3] virtio-net: Convert feature properties to OnOffAuto
Date: Wed, 1 May 2024 16:20:41 +0900 [thread overview]
Message-ID: <e7b29a10-addf-4fed-9092-73652cb16cce@daynix.com> (raw)
In-Reply-To: <20240429030329-mutt-send-email-mst@kernel.org>
On 2024/04/29 16:05, Michael S. Tsirkin wrote:
> On Sun, Apr 28, 2024 at 04:21:06PM +0900, Akihiko Odaki wrote:
>> Based-on: <20240428-rss-v10-0-73cbaa91aeb6@daynix.com>
>> ("[PATCH v10 00/18] virtio-net RSS/hash report fixes and improvements")
>>
>> Some features are not always available, and virtio-net used to disable
>> them when not available even if the corresponding properties were
>> explicitly set to "on".
>>
>> Convert feature properties to OnOffAuto so that the user can explicitly
>> tell QEMU to automatically select the value by setting them "auto".
>> QEMU will give an error if they are set "on".
>>
>> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
>
> Should we maybe bite the bullet allow "auto" for all binary/boolean
> properties? Just ignore "auto" if no one cares ATM.
It is not always obvious whether "auto" should be considered as "on" or
"off" for existing boolean properties. The properties this patch deals
with are to enable features so "auto" should be considered as "on" if
possible. However, other properties may mean to disable features, and in
such a case, "auto" should be considered as "off".
It may still make sense to accept "auto" for all virtio-net feature bits
for consistency. In particular, I left guest_rsc_ext property boolean
since nobody cares "auto" for that feature, but this can be converted to
OnOffAuto.
next prev parent reply other threads:[~2024-05-01 7:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-28 7:21 [PATCH 0/3] virtio-net: Convert feature properties to OnOffAuto Akihiko Odaki
2024-04-28 7:21 ` [PATCH 1/3] qdev-properties: Add DEFINE_PROP_ON_OFF_AUTO_BIT64() Akihiko Odaki
2024-04-30 14:41 ` Yuri Benditovich
2024-05-01 6:36 ` Akihiko Odaki
2024-04-28 7:21 ` [PATCH 2/3] virtio-net: Convert feature properties to OnOffAuto Akihiko Odaki
2024-04-30 15:02 ` Yuri Benditovich
2024-05-01 7:06 ` Akihiko Odaki
2024-04-28 7:21 ` [PATCH 3/3] virtio-net: Report RSS warning at device realization Akihiko Odaki
2024-04-29 7:05 ` [PATCH 0/3] virtio-net: Convert feature properties to OnOffAuto Michael S. Tsirkin
2024-05-01 7:20 ` Akihiko Odaki [this message]
2024-05-06 3:48 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7b29a10-addf-4fed-9092-73652cb16cce@daynix.com \
--to=akihiko.odaki@daynix.com \
--cc=20240428-rss-v10-0-73cbaa91aeb6@daynix.com \
--cc=andrew@daynix.com \
--cc=berrange@redhat.com \
--cc=dmitry.fleytman@gmail.com \
--cc=eduardo@habkost.net \
--cc=g.lettieri@iet.unipi.it \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rizzo@iet.unipi.it \
--cc=sriram.yagnaraman@ericsson.com \
--cc=v.maffione@gmail.com \
--cc=yuri.benditovich@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).