From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>, Warner Losh <imp@bsdimp.com>,
Richard Henderson <richard.henderson@linaro.org>,
Kyle Evans <kevans@freebsd.org>,
Ilya Leoshkevich <iii@linux.ibm.com>,
Riku Voipio <riku.voipio@iki.fi>,
Laurent Vivier <laurent@vivier.eu>
Subject: Re: [PATCH v3 1/5] accel/tcg: Move SoftMMU specific units to softmmu_specific_ss[]
Date: Mon, 6 May 2024 17:40:49 +0200 [thread overview]
Message-ID: <de27bf37-2487-4c3e-b2fb-6623a744d9f7@linaro.org> (raw)
In-Reply-To: <20240503123456.28866-2-philmd@linaro.org>
On 3/5/24 14:34, Philippe Mathieu-Daudé wrote:
> Currently these files are only used in system emulation,
> but could eventually be used by user emulation. Use the
> "softmmu_specific_ss" to express they are related to
> SoftMMU.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> accel/tcg/meson.build | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/accel/tcg/meson.build b/accel/tcg/meson.build
> index aef80de967..84826f043a 100644
> --- a/accel/tcg/meson.build
> +++ b/accel/tcg/meson.build
> @@ -16,12 +16,13 @@ tcg_specific_ss.add(when: 'CONFIG_SYSTEM_ONLY', if_false: files('user-exec-stub.
> if get_option('plugins')
> tcg_specific_ss.add(files('plugin-gen.c'))
> endif
> -specific_ss.add_all(when: 'CONFIG_TCG', if_true: tcg_specific_ss)
>
> -specific_ss.add(when: ['CONFIG_SYSTEM_ONLY', 'CONFIG_TCG'], if_true: files(
> +softmmu_specific_ss = ss.source_set()
> +softmmu_specific_ss.add(files(
> 'cputlb.c',
> 'watchpoint.c',
> ))
> +tcg_specific_ss.add(when: 'CONFIG_SYSTEM_ONLY', if_true: softmmu_specific_ss)
Should be .add_all() here.
> system_ss.add(when: ['CONFIG_TCG'], if_true: files(
> 'icount-common.c',
> @@ -34,3 +35,5 @@ tcg_module_ss.add(when: ['CONFIG_SYSTEM_ONLY', 'CONFIG_TCG'], if_true: files(
> 'tcg-accel-ops-icount.c',
> 'tcg-accel-ops-rr.c',
> ))
> +
> +specific_ss.add_all(when: 'CONFIG_TCG', if_true: tcg_specific_ss)
next prev parent reply other threads:[~2024-05-06 15:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-03 12:34 [PATCH v3 0/5] accel/tcg: Call tcg_flush_jmp_cache() again when creating user-mode cpu Philippe Mathieu-Daudé
2024-05-03 12:34 ` [PATCH v3 1/5] accel/tcg: Move SoftMMU specific units to softmmu_specific_ss[] Philippe Mathieu-Daudé
2024-05-06 15:40 ` Philippe Mathieu-Daudé [this message]
2024-05-03 12:34 ` [PATCH v3 2/5] accel/tcg: Move system emulation files under sysemu/ subdirectory Philippe Mathieu-Daudé
2024-05-03 12:34 ` [PATCH v3 3/5] accel/tcg: Do not define cpu_exec_reset_hold() as stub Philippe Mathieu-Daudé
2024-05-03 12:34 ` [PATCH v3 4/5] accel/tcg: Introduce common tcg_exec_cpu_reset_hold() method Philippe Mathieu-Daudé
2024-05-03 12:34 ` [PATCH v3 5/5] accel/tcg: Always call tcg_flush_jmp_cache() on reset Philippe Mathieu-Daudé
2024-05-16 11:17 ` Fiona Ebner
2024-05-03 15:10 ` [PATCH v3 0/5] accel/tcg: Call tcg_flush_jmp_cache() again when creating user-mode cpu Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de27bf37-2487-4c3e-b2fb-6623a744d9f7@linaro.org \
--to=philmd@linaro.org \
--cc=iii@linux.ibm.com \
--cc=imp@bsdimp.com \
--cc=kevans@freebsd.org \
--cc=laurent@vivier.eu \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).