From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F267C47082 for ; Tue, 8 Jun 2021 21:44:50 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2D0F36139A for ; Tue, 8 Jun 2021 21:44:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2D0F36139A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53574 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lqjWj-0002GC-A8 for qemu-devel@archiver.kernel.org; Tue, 08 Jun 2021 17:44:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39256) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lqjVR-0008Vr-JP for qemu-devel@nongnu.org; Tue, 08 Jun 2021 17:43:29 -0400 Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]:41804) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lqjVO-0005OQ-NK for qemu-devel@nongnu.org; Tue, 08 Jun 2021 17:43:29 -0400 Received: by mail-pf1-x42b.google.com with SMTP id x73so16772119pfc.8 for ; Tue, 08 Jun 2021 14:43:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:from:to:references:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=mKdpvDDDh7/f/2lUu+Ih0bHWPmxVoxiRmcXaKviEDVQ=; b=dqLReeTikT4MqdPzXxuFLWNcdsyae0uHfrxCVLmoPUD66R6d+nzlOchoThBR77QGt3 gcOXgXqdRbc8Q9VQnOEctq7tSpLNBIKIofnHZGYhO/3WrMl9FPjsljU/W0yhjvlu0Csx sFQiEYLxOPqO0au21dGJb179vWORlm6rxqD8hkI5QhUhH78nMsD/Idv4YtujbjrlhMpj P9O0a7m3wl/crSolMZMamZ5aMlYsfha3R6cTYAuwPUjhqtxQRMe8qCiEJQe/KHUDS3+k xqK+t79luZtYeMkVXeaDniUh2PtVF8ehXoXWXA2zXc2svlyqzadq+WoX8sqybGM98EBa /DbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=mKdpvDDDh7/f/2lUu+Ih0bHWPmxVoxiRmcXaKviEDVQ=; b=kwowUz200f7zAiyRMqDNqEn6GW1ozeyE33m+U4lEdcL2FzktOow5Tw9CfYTp6z3eAb 2EkGJfyCh/PoquuhjwMut1JpfyMgK38ejfk4pb5LhzZN3hu5pIA55Zo152nejezMX5Sf cfcGYNvBHur0bxCpChhN08BOPnUm0xd0D8/6zhPVD8T9nKWwMs/xCLucRO+Cxr+/Xon1 C+F7mzRMl7u8fAP+9M78gZVOdowwCKQJ79qdRw7vwKEH+OOIoVq8kILVmKcqzrTIbU7Q kLHbbcq7SwkBUu+iMqWwgO7lJaVEzmQ8zXvvIiMqHLY6/FmlbVXB1tEHQq7dly54wQY6 bCJA== X-Gm-Message-State: AOAM533LUfVwgzQ+/U4L68xlRFGpddDuDuWfOMbkrqjiiqK5qHnSqLQ/ 5Id8ycvj3YtqIw0LC4XPjQtu1BUduft0Vw== X-Google-Smtp-Source: ABdhPJzdDlTVldaOub47beeoRG3m8vOf9Q/o0Q89csMOHgmUs/CgxAT7JMyCCxhCgdgG0iQVj4QfbQ== X-Received: by 2002:aa7:9a97:0:b029:2e9:e1fb:2f0d with SMTP id w23-20020aa79a970000b02902e9e1fb2f0dmr1945979pfi.45.1623188604883; Tue, 08 Jun 2021 14:43:24 -0700 (PDT) Received: from [192.168.1.11] (174-21-70-228.tukw.qwest.net. [174.21.70.228]) by smtp.gmail.com with ESMTPSA id ei23sm3219385pjb.57.2021.06.08.14.43.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Jun 2021 14:43:24 -0700 (PDT) Subject: Re: [PATCH 11/55] target/arm: Implement MVE VLDR/VSTR (non-widening forms) From: Richard Henderson To: Peter Maydell , qemu-arm@nongnu.org, qemu-devel@nongnu.org References: <20210607165821.9892-1-peter.maydell@linaro.org> <20210607165821.9892-12-peter.maydell@linaro.org> Message-ID: Date: Tue, 8 Jun 2021 14:43:23 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::42b; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 6/8/21 2:33 PM, Richard Henderson wrote: > >> +static bool trans_VLDR_VSTR(DisasContext *s, arg_VLDR_VSTR *a) >> +{ >> +    MVEGenLdStFn *ldfns[] = { > > static MVEGenLdStFn * const ldfns > >> +    MVEGenLdStFn *stfns[] = { > > Likewise, though... > >> +    return do_ldst(s, a, a->l ? ldfns[a->size] : stfns[a->size]); > > ... just put em together into a two-dimensional array, with a->l as the second > index? ... or separate VLDR from VSTR. r~