From: Richard Henderson <richard.henderson@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH] target/i386: remove PCOMMIT from TCG, deprecate property
Date: Thu, 9 May 2024 15:40:31 +0200 [thread overview]
Message-ID: <b66b782f-c6a2-4ab9-84d3-4e1dabd1159f@linaro.org> (raw)
In-Reply-To: <20240508154421.61419-1-pbonzini@redhat.com>
On 5/8/24 17:44, Paolo Bonzini wrote:
> The PCOMMIT instruction was never included in any physical processor.
> TCG implements it as a no-op instruction, but its utility is debatable
> to say the least. Drop it from the decoder since it is only available
> with "-cpu max", which does not guarantee migration compatibility
> across versions, and deprecate the property just in case someone is
> using it as "pcommit=off".
>
> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
> ---
> docs/about/deprecated.rst | 8 ++++++++
> target/i386/cpu.h | 2 --
> target/i386/cpu.c | 2 +-
> target/i386/tcg/translate.c | 12 +-----------
> 4 files changed, 10 insertions(+), 14 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2024-05-09 13:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 15:44 [PATCH] target/i386: remove PCOMMIT from TCG, deprecate property Paolo Bonzini
2024-05-09 13:40 ` Richard Henderson [this message]
2024-05-10 12:53 ` Zhao Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b66b782f-c6a2-4ab9-84d3-4e1dabd1159f@linaro.org \
--to=richard.henderson@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).