QEMU-Devel Archive mirror
 help / color / mirror / Atom feed
From: Avihai Horon <avihaih@nvidia.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org,
	"Alex Williamson" <alex.williamson@redhat.com>,
	"Cédric Le Goater" <clg@redhat.com>,
	"Michael Roth" <michael.roth@amd.com>,
	"Eric Blake" <eblake@redhat.com>, "Peter Xu" <peterx@redhat.com>,
	"Fabiano Rosas" <farosas@suse.de>,
	"Joao Martins" <joao.m.martins@oracle.com>,
	"Maor Gottlieb" <maorg@nvidia.com>
Subject: Re: [PATCH 1/3] qapi/vfio: Add VFIO device migration state change QAPI event
Date: Mon, 6 May 2024 12:59:48 +0300	[thread overview]
Message-ID: <aeac0202-c474-4276-97d1-8329f357b6fd@nvidia.com> (raw)
In-Reply-To: <871q6ftv5w.fsf@pond.sub.org>


On 06/05/2024 7:35, Markus Armbruster wrote:
> External email: Use caution opening links or attachments
>
>
> Avihai Horon <avihaih@nvidia.com> writes:
>
>> On 02/05/2024 14:19, Markus Armbruster wrote:
>>> External email: Use caution opening links or attachments
>>>
>>>
>>> Avihai Horon <avihaih@nvidia.com> writes:
>>>
>>>> Add a new QAPI event for VFIO device migration state change. This event
>>>> will be emitted when a VFIO device changes its migration state, for
>>>> example, during migration or when stopping/starting the guest.
>>>>
>>>> This event can be used by management applications to get updates on the
>>>> current state of the VFIO device for their own purposes.
>>>>
>>>> Signed-off-by: Avihai Horon <avihaih@nvidia.com>
>>> Can you explain briefly why this event makes sense only for VFIO devices?
>> VFIO devices have their own protocol for migration and a unique set of migration states.
>> This event holds info about these VFIO migration states, which I think cannot be described in the same accuracy by other events such as run state or migration states.
> Would it make sense to work this into the commit message?

Sure, it wouldn't hurt. I will add it.



  reply	other threads:[~2024-05-06 10:05 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-30  5:16 [PATCH 0/3] qapi/vfio: Add VFIO device migration state change QAPI event Avihai Horon
2024-04-30  5:16 ` [PATCH 1/3] " Avihai Horon
2024-05-01 11:50   ` Joao Martins
2024-05-01 12:08     ` Avihai Horon
2024-05-06  4:52       ` Markus Armbruster
2024-05-06 10:07         ` Avihai Horon
2024-05-06 10:36           ` Markus Armbruster
2024-05-06 10:57             ` Avihai Horon
2024-05-02 11:19   ` Markus Armbruster
2024-05-05  7:48     ` Avihai Horon
2024-05-06  4:35       ` Markus Armbruster
2024-05-06  9:59         ` Avihai Horon [this message]
2024-04-30  5:16 ` [PATCH 2/3] vfio/migration: Emit " Avihai Horon
2024-05-01 11:50   ` Joao Martins
2024-05-01 12:28     ` Avihai Horon
2024-05-02 10:22       ` Joao Martins
2024-05-05  7:28         ` Avihai Horon
2024-05-06  4:56           ` Markus Armbruster
2024-05-06 14:38             ` Fabiano Rosas
2024-05-06 15:07               ` Peter Xu
2024-05-07  7:47                 ` Avihai Horon
2024-05-07 15:51                   ` Peter Xu
2024-05-07 16:21                     ` Avihai Horon
2024-04-30  5:16 ` [PATCH 3/3] vfio/migration: Don't emit STOP_COPY state change event twice Avihai Horon
2024-05-06 14:39   ` Cédric Le Goater
2024-05-06 15:01     ` Avihai Horon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aeac0202-c474-4276-97d1-8329f357b6fd@nvidia.com \
    --to=avihaih@nvidia.com \
    --cc=alex.williamson@redhat.com \
    --cc=armbru@redhat.com \
    --cc=clg@redhat.com \
    --cc=eblake@redhat.com \
    --cc=farosas@suse.de \
    --cc=joao.m.martins@oracle.com \
    --cc=maorg@nvidia.com \
    --cc=michael.roth@amd.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).