From: "Daniel P. Berrangé" <berrange@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: qemu-devel@nongnu.org,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Laurent Vivier" <lvivier@redhat.com>
Subject: Re: [PATCH v2 3/3] crypto: Allow building with GnuTLS but without Libtasn1
Date: Fri, 17 May 2024 10:07:32 +0100 [thread overview]
Message-ID: <ZkceVO9e0kaLCSlN@redhat.com> (raw)
In-Reply-To: <20240502095642.93368-4-philmd@linaro.org>
On Thu, May 02, 2024 at 11:56:42AM +0200, Philippe Mathieu-Daudé wrote:
> We only use Libtasn1 in unit tests. As noted in commit d47b83b118
> ("tests: add migration tests of TLS with x509 credentials"), having
> GnuTLS without Libtasn1 is a valid configuration, so do not require
> Libtasn1, to avoid:
>
> Dependency gnutls found: YES 3.7.1 (cached)
> Run-time dependency libtasn1 found: NO (tried pkgconfig)
>
> ../meson.build:1914:10: ERROR: Dependency "libtasn1" not found, tried pkgconfig
>
> Fixes: ba7ed407e6 ("configure, meson: convert libtasn1 detection to meson")
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> meson.build | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2024-05-17 9:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-02 9:56 [PATCH v2 0/3] crypto: Allow building with GnuTLS but without Libtasn1 Philippe Mathieu-Daudé
2024-05-02 9:56 ` [PATCH v2 1/3] crypto: Remove 'crypto-tls-x509-helpers.h' from crypto-tls-psk-helpers.c Philippe Mathieu-Daudé
2024-05-17 9:04 ` Daniel P. Berrangé
2024-05-02 9:56 ` [PATCH v2 2/3] crypto: Restrict pkix_asn1_tab[] to crypto-tls-x509-helpers.c Philippe Mathieu-Daudé
2024-05-17 9:07 ` Daniel P. Berrangé
2024-05-02 9:56 ` [PATCH v2 3/3] crypto: Allow building with GnuTLS but without Libtasn1 Philippe Mathieu-Daudé
2024-05-17 9:07 ` Daniel P. Berrangé [this message]
2024-05-17 9:12 ` Daniel P. Berrangé
2024-05-08 14:30 ` [PATCH v2 0/3] " Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZkceVO9e0kaLCSlN@redhat.com \
--to=berrange@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).