From: Peter Xu <peterx@redhat.com>
To: Li Zhijian <lizhijian@fujitsu.com>
Cc: Fabiano Rosas <farosas@suse.de>,
Hailiang Zhang <zhanghailiang@xfusion.com>,
qemu-devel@nongnu.org, Zhang Chen <chen.zhang@intel.com>,
Michael Tokarev <mjt@tls.msk.ru>
Subject: Re: [PATCH 3/3] migration/colo: Tidy up bql_unlock() around bdrv_activate_all()
Date: Thu, 9 May 2024 09:38:08 -0400 [thread overview]
Message-ID: <ZjzRwLOijr91ir2M@x1n> (raw)
In-Reply-To: <20240509033106.1321880-3-lizhijian@fujitsu.com>
On Thu, May 09, 2024 at 11:31:06AM +0800, Li Zhijian via wrote:
> Make the code more tight.
>
> Cc: Michael Tokarev <mjt@tls.msk.ru>
> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
> ---
> This change/comment suggested by "Michael Tokarev <mjt@tls.msk.ru>" came
> a bit late at that time, let's update it together in these minor set
> this time.
You can use a tag next time:
Suggested-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
> migration/colo.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/migration/colo.c b/migration/colo.c
> index 991806c06a..1b6d9da1c8 100644
> --- a/migration/colo.c
> +++ b/migration/colo.c
> @@ -838,12 +838,11 @@ static void *colo_process_incoming_thread(void *opaque)
> /* Make sure all file formats throw away their mutable metadata */
> bql_lock();
> bdrv_activate_all(&local_err);
> + bql_unlock();
> if (local_err) {
> - bql_unlock();
> error_report_err(local_err);
> return NULL;
> }
> - bql_unlock();
>
> failover_init_state();
>
> --
> 2.31.1
>
>
--
Peter Xu
next prev parent reply other threads:[~2024-05-09 13:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 3:31 [PATCH 1/3] migration/colo: Minor fix for colo error message Li Zhijian via
2024-05-09 3:31 ` [PATCH 2/3] migration/colo: make colo_incoming_co() return void Li Zhijian via
2024-05-09 13:37 ` Peter Xu
2024-05-11 2:51 ` Zhang, Chen
2024-05-15 19:04 ` Fabiano Rosas
2024-05-16 3:37 ` Zhijian Li (Fujitsu) via
2024-05-09 3:31 ` [PATCH 3/3] migration/colo: Tidy up bql_unlock() around bdrv_activate_all() Li Zhijian via
2024-05-09 13:38 ` Peter Xu [this message]
2024-05-11 2:51 ` Zhang, Chen
2024-05-09 13:33 ` [PATCH 1/3] migration/colo: Minor fix for colo error message Peter Xu
2024-05-11 2:51 ` Zhang, Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjzRwLOijr91ir2M@x1n \
--to=peterx@redhat.com \
--cc=chen.zhang@intel.com \
--cc=farosas@suse.de \
--cc=lizhijian@fujitsu.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=zhanghailiang@xfusion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).