From: Kevin Wolf <kwolf@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
qemu-devel@nongnu.org,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Miroslav Rezanina <mrezanin@redhat.com>,
qemu-block@nongnu.org
Subject: Re: [PATCH 0/3] Make it possible to compile the x86 binaries without FDC
Date: Mon, 29 Apr 2024 12:31:30 +0200 [thread overview]
Message-ID: <Zi93AtlPTdjmpgfu@redhat.com> (raw)
In-Reply-To: <20240425184315.553329-1-thuth@redhat.com>
[ Cc: qemu-block ]
Am 25.04.2024 um 20:43 hat Thomas Huth geschrieben:
> For downstream versions of QEMU, we'd like to be able to compile QEMU
> without the FDC code included (since it's not required for modern VMs
> anymore and the FDC code has rather a bad reputation, see the VENOM CVE).
>
> The q35 machine can already be instantiated without FDC, but for being
> able to link a binary without the FDC code, the Kconfig file needs some
> tweaks and there are two spots in the pc code that directly call functions
> from the FDC code - those need to be disabled via #ifdefs.
>
> The third patch changes the i440fx and isapc machine types so that
> they can work without the FDC device, too, in case it has not been
> compiled into the binary. It's marked as RFC since I assume that the
> FDC was originally a fix compononent of these motherboards, so I'm
> unsure whether we should allow the disablement there. OTOH, it seems
> to work fine, and the FDC is only disabled when it is not available
> in the binary, so I hope this patch is fine, too.
>
> Thomas Huth (3):
> hw/i386/pc: Allow to compile without CONFIG_FDC_ISA
> hw/i386/Kconfig: Allow to compile Q35 without FDC_ISA
> hw/i386: Add the possibility to use i440fx and isapc without FDC
>
> hw/i386/pc.c | 13 +++++++++----
> hw/i386/pc_piix.c | 6 ++++--
> hw/i386/Kconfig | 2 +-
> 3 files changed, 14 insertions(+), 7 deletions(-)
>
> --
> 2.44.0
>
>
next prev parent reply other threads:[~2024-04-29 10:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 18:43 [PATCH 0/3] Make it possible to compile the x86 binaries without FDC Thomas Huth
2024-04-25 18:43 ` [PATCH 1/3] hw/i386/pc: Allow to compile without CONFIG_FDC_ISA Thomas Huth
2024-05-06 14:26 ` Philippe Mathieu-Daudé
2024-04-25 18:43 ` [PATCH 2/3] hw/i386/Kconfig: Allow to compile Q35 without FDC_ISA Thomas Huth
2024-04-25 18:43 ` [RFC PATCH 3/3] hw/i386: Add the possibility to use i440fx and isapc without FDC Thomas Huth
2024-04-25 20:56 ` [PATCH 0/3] Make it possible to compile the x86 binaries " Philippe Mathieu-Daudé
2024-04-26 5:08 ` Thomas Huth
2024-04-29 10:31 ` Kevin Wolf [this message]
2024-05-06 14:27 ` Philippe Mathieu-Daudé
2024-05-06 15:59 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zi93AtlPTdjmpgfu@redhat.com \
--to=kwolf@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mrezanin@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).