On Wed, Jun 16, 2021 at 01:36:10PM +0100, Dr. David Alan Gilbert wrote: > * Stefan Hajnoczi (stefanha@redhat.com) wrote: > > On Thu, Jun 10, 2021 at 04:29:42PM +0100, Dr. David Alan Gilbert wrote: > > > * Dr. David Alan Gilbert (dgilbert@redhat.com) wrote: > > > > * Stefan Hajnoczi (stefanha@redhat.com) wrote: > > > + uint64_t addr; /* In the bus address of the device */ > > > > Please check the spec for preferred terminology. "bus address" isn't > > used in the spec, so there's probably another term for it. > > I'm not seeing anything useful in the virtio spec; it mostly talks about > guest physical addresses; it does say 'bus addresses' in the definition > of 'VIRTIO_F_ACCESS_PLATFORM' . I meant the docs/interop/vhost-user.rst spec. Stefan