From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9BB4C47094 for ; Thu, 10 Jun 2021 13:27:29 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5C52D613E7 for ; Thu, 10 Jun 2021 13:27:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5C52D613E7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33862 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lrKiW-000296-Eb for qemu-devel@archiver.kernel.org; Thu, 10 Jun 2021 09:27:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45326) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lrKgb-00082m-Es for qemu-devel@nongnu.org; Thu, 10 Jun 2021 09:25:29 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:58155) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lrKgY-0006u3-IR for qemu-devel@nongnu.org; Thu, 10 Jun 2021 09:25:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623331525; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+ETRxrM0KOTBszXax2tI21KItJOghe5zPm+y2qsFdT0=; b=Mgrd/PhyouQuHRhg9prt4QPJJoN8iS2IChXSAU3JQhAKyRjtygOGGn1NzTYrW0Fs30XJLO kednRPScHhjunE5t9jnhW1eyE7QR0bqHt7LVRXGL67Zh/DTRIiXyxwTfn0JgrvIb35ih3e /JTz5AbDsnL4IxMfGfnbf3wmd6PtUeM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-15-YqmASSJwMaKDD1VxeYGNgg-1; Thu, 10 Jun 2021 09:25:23 -0400 X-MC-Unique: YqmASSJwMaKDD1VxeYGNgg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 52D70192297C; Thu, 10 Jun 2021 13:25:21 +0000 (UTC) Received: from redhat.com (ovpn-115-203.ams2.redhat.com [10.36.115.203]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4FB49100238C; Thu, 10 Jun 2021 13:25:16 +0000 (UTC) Date: Thu, 10 Jun 2021 14:25:12 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Peng Liang Subject: Re: [PATCH] runstate: Initialize Error * to NULL Message-ID: References: <20210610131729.3906565-1-liangpeng10@huawei.com> MIME-Version: 1.0 In-Reply-To: <20210610131729.3906565-1-liangpeng10@huawei.com> User-Agent: Mutt/2.0.7 (2021-05-04) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.199, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: alex.bennee@linaro.org, alejandro.j.jimenez@oracle.com, armbru@redhat.com, xiexiangyou@huawei.com, qemu-devel@nongnu.org, pbonzini@redhat.com, philmd@redhat.com, laurent@vivier.eu Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Jun 10, 2021 at 09:17:29PM +0800, Peng Liang wrote: > Based on the description of error_setg(), the local variable err in > qemu_init_subsystems() should be initialized to NULL. > > Fix: efd7ab22fb "vl: extract qemu_init_subsystems" > Signed-off-by: Peng Liang > --- > The patch is generated by the following coccinelle script (thanks to > Markus): > @ r @ > identifier id; > @@ > ( > static Error *id; > | > Error *id > + = NULL > ; > ) > And exclude the modifications in softmmu/vl.c (which has fixed by > Zhenzhong Duan already) and util/error.c (which are unnecessary). > > softmmu/runstate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|