From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E17A2C433ED for ; Wed, 5 May 2021 15:59:54 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5D9DB613BF for ; Wed, 5 May 2021 15:59:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D9DB613BF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50634 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1leJwH-0000Fb-BD for qemu-devel@archiver.kernel.org; Wed, 05 May 2021 11:59:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55696) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1leJuS-00077E-5D for qemu-devel@nongnu.org; Wed, 05 May 2021 11:58:00 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:24661) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1leJuP-0005zm-Hd for qemu-devel@nongnu.org; Wed, 05 May 2021 11:57:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620230276; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MK6EnlR2xVGAGP6VOkN1LDuWe7lPXiuJf109TBJoDwM=; b=cgy294AUui43OFFZ9oHiB/+03wiXXMSKe85vt4uBkG9BixLU1pR6CW1EcQMQ8GiQd4EPVo kMEzevEsILyvq7gf/lSO2TB1MqSa5op4nuZXVf/YNjyZKGMwcePQaZninlW6dFfeuNT8cu wMpopeWlM/tl2stbkFIXPNuKEUdcIVk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-502-BAmkBV7cN4uI8Zg6ysTyeg-1; Wed, 05 May 2021 11:57:52 -0400 X-MC-Unique: BAmkBV7cN4uI8Zg6ysTyeg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E428D1006C81; Wed, 5 May 2021 15:57:51 +0000 (UTC) Received: from merkur.fritz.box (ovpn-115-138.ams2.redhat.com [10.36.115.138]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CDE512BFE1; Wed, 5 May 2021 15:57:49 +0000 (UTC) Date: Wed, 5 May 2021 17:57:48 +0200 From: Kevin Wolf To: Alberto Garcia Subject: Re: [PATCH v4 3/6] iotests: Test replacing files with x-blockdev-reopen Message-ID: References: <6e521df2f95da4a8df679bf15ad6cb4af33fe18f.1616000692.git.berto@igalia.com> MIME-Version: 1.0 In-Reply-To: <6e521df2f95da4a8df679bf15ad6cb4af33fe18f.1616000692.git.berto@igalia.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kwolf@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=170.10.133.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.693, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org, qemu-block@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Am 17.03.2021 um 18:15 hat Alberto Garcia geschrieben: > This patch adds new tests in which we use x-blockdev-reopen to change > bs->file > > Signed-off-by: Alberto Garcia Looks good, but I wonder if we should also test the error paths. I think we're testing them for backing files, but as patch 2 shows, we need to check different things for update the file link. Kevin