From: "Kim, Dongwon" <dongwon.kim@intel.com>
To: "Kim, Dongwon" <dongwon.kim@intel.com>,
"Marc-André Lureau" <marcandre.lureau@gmail.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"kraxel@redhat.com" <kraxel@redhat.com>
Subject: RE: [PATCH] ui/gtk: Explicitly set the default size of new window when untabifying
Date: Wed, 8 May 2024 00:02:07 +0000 [thread overview]
Message-ID: <PH8PR11MB6879F8708F95322D3FF23133FAE52@PH8PR11MB6879.namprd11.prod.outlook.com> (raw)
In-Reply-To: <PH8PR11MB6879CC01FED69C2965252F19FAE42@PH8PR11MB6879.namprd11.prod.outlook.com>
Hi Marc-André,
I found that the problem is actually due to scaling factor of 0.25 (VC_SCALE_MIN).
static void gd_update_geometry_hints(VirtualConsole *vc)
{
GtkDisplayState *s = vc->s;
GdkWindowHints mask = 0;
GdkGeometry geo = {};
GtkWidget *geo_widget = NULL;
GtkWindow *geo_window;
if (vc->type == GD_VC_GFX) {
if (!vc->gfx.ds) {
return;
}
if (s->free_scale) {
geo.min_width = surface_width(vc->gfx.ds) * VC_SCALE_MIN;
geo.min_height = surface_height(vc->gfx.ds) * VC_SCALE_MIN;
mask |= GDK_HINT_MIN_SIZE;
} else {
geo.min_width = surface_width(vc->gfx.ds) * vc->gfx.scale_x;
geo.min_height = surface_height(vc->gfx.ds) * vc->gfx.scale_y;
mask |= GDK_HINT_MIN_SIZE;
}
geo_widget = vc->gfx.drawing_area;
gtk_widget_set_size_request(geo_widget, geo.min_width, geo.min_height);
s->free_scale is set when 'zoom_to_fit' is set. This 'zoom_to_fit' is normally set via param but it is unconditionally set when
ui_info is supported like when some display device is enabled like virtio-vga.
So here free_scale is true so min_width and min_height are set to 1/4 of original width/height of the surface (640x480). That is totally fine.
But the real problem is at
gtk_widget_set_size_request(geo_widget, geo.min_width, geo.min_height);
I do not understand why we are making set size request with these "min" values.
This commit from Gerd originally introduced the 0.25 scaling factor but not sure what is intention there.
(I hope Gerd can comment on this.)
commit 82fc18099aa8ee2533add523cc0069f26a83e7b6
Author: Gerd Hoffmann <kraxel@redhat.com>
Date: Fri May 16 12:26:12 2014 +0200
gtk: window sizing overhaul
Major overhaul for window size handling. This basically switches qemu
over to use geometry hints for the window manager instead of trying to
get the job done with widget resize requests. This allows to specify
better what we need and also avoids window resizes.
FIXME: on gtk2 someone overwrites the geometry hints :(
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
I am wondering if we could just set geo.base_width and height to the normal size then use these instead when making size request there.
Can you share your thought?
Thanks,
DW
> -----Original Message-----
> From: qemu-devel-bounces+dongwon.kim=intel.com@nongnu.org <qemu-
> devel-bounces+dongwon.kim=intel.com@nongnu.org> On Behalf Of Kim,
> Dongwon
> Sent: Tuesday, May 7, 2024 9:06 AM
> To: Marc-André Lureau <marcandre.lureau@gmail.com>
> Cc: qemu-devel@nongnu.org; kraxel@redhat.com
> Subject: RE: [PATCH] ui/gtk: Explicitly set the default size of new window when
> untabifying
>
> Hi Marc-André,
>
> > -----Original Message-----
> > From: Marc-André Lureau <marcandre.lureau@gmail.com>
> > Sent: Tuesday, May 7, 2024 8:10 AM
> > To: Kim, Dongwon <dongwon.kim@intel.com>
> > Cc: qemu-devel@nongnu.org; kraxel@redhat.com
> > Subject: Re: [PATCH] ui/gtk: Explicitly set the default size of new
> > window when untabifying
> >
> > Hi
> >
> > On Wed, May 1, 2024 at 7:47 AM <dongwon.kim@intel.com> wrote:
> > >
> > > From: Dongwon Kim <dongwon.kim@intel.com>
> > >
> > > When untabifying, the default size of the new window was
> > > inadvertently set to the size smaller than quarter of the primary
> > > window size due to lack of explicit configuration. This commit
> > > addresses the issue by ensuring that the size of untabified windows
> > > is set to match the surface size.
> >
> > From a quick test, I don't see a difference of behaviour after the
> > patch. Could you help me reproduce the issue?
> >
> > I also don't think it is correct for two reasons:
> > - the inner display widget should cause a window size reconfiguration
> > - the window size != display size
>
> [Kim, Dongwon] Ok, I see this is happening only when virtio-vga device is used
> like
> qemu-system-x86_64 -m 2048 -enable-kvm -cpu host -smp cores=2 -drive
> file=./OVMF.fd,format=raw,if=pflash -device virtio-vga -display gtk,gl=on Maybe
> some setting of dimensions is missing in there? I will take a look.
>
> >
> > thanks
> >
> > > Cc: Gerd Hoffmann <kraxel@redhat.com>
> > > Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
> > > Cc: Vivek Kasireddy <vivek.kasireddy@intel.com>
> > > Signed-off-by: Dongwon Kim <dongwon.kim@intel.com>
> > > ---
> > > ui/gtk.c | 3 +++
> > > 1 file changed, 3 insertions(+)
> > >
> > > diff --git a/ui/gtk.c b/ui/gtk.c
> > > index 810d7fc796..269b8207d7 100644
> > > --- a/ui/gtk.c
> > > +++ b/ui/gtk.c
> > > @@ -1395,6 +1395,9 @@ static void gd_menu_untabify(GtkMenuItem
> > > *item,
> > void *opaque)
> > > if (!vc->window) {
> > > gtk_widget_set_sensitive(vc->menu_item, false);
> > > vc->window = gtk_window_new(GTK_WINDOW_TOPLEVEL);
> > > + gtk_window_set_default_size(GTK_WINDOW(vc->window),
> > > + surface_width(vc->gfx.ds),
> > > + surface_height(vc->gfx.ds));
> > > #if defined(CONFIG_OPENGL)
> > > if (vc->gfx.esurface) {
> > > eglDestroySurface(qemu_egl_display, vc->gfx.esurface);
> > > --
> > > 2.34.1
> > >
> > >
> >
> >
> > --
> > Marc-André Lureau
prev parent reply other threads:[~2024-05-08 0:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-01 3:41 [PATCH] ui/gtk: Explicitly set the default size of new window when untabifying dongwon.kim
2024-05-07 15:10 ` Marc-André Lureau
2024-05-07 16:05 ` Kim, Dongwon
2024-05-08 0:02 ` Kim, Dongwon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH8PR11MB6879F8708F95322D3FF23133FAE52@PH8PR11MB6879.namprd11.prod.outlook.com \
--to=dongwon.kim@intel.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).