From: "Nicholas Piggin" <npiggin@gmail.com>
To: "Cédric Le Goater" <clg@kaod.org>, qemu-ppc@nongnu.org
Cc: qemu-devel@nongnu.org, "Frédéric Barrat" <fbarrat@linux.ibm.com>,
"Saif Abrar" <saif.abrar@linux.vnet.ibm.com>
Subject: Re: [PATCH 1/2] ppc/pnv: Begin a more complete ADU LPC model for POWER9/10
Date: Fri, 03 May 2024 14:51:46 +1000 [thread overview]
Message-ID: <D0ZQN2YAQ28S.3FGETJPE6XVC8@gmail.com> (raw)
In-Reply-To: <272a9f32-8d32-4681-b25b-9d45c6c787b5@kaod.org>
On Thu May 2, 2024 at 6:47 PM AEST, Cédric Le Goater wrote:
> On 5/1/24 14:39, Nicholas Piggin wrote:
> > On Wed Apr 17, 2024 at 9:25 PM AEST, Cédric Le Goater wrote:
> >> Hello Nick,
> >>
> >> On 4/17/24 13:02, Nicholas Piggin wrote:
> >>> This implements a framework for an ADU unit model.
> >>>
> >>> The ADU unit actually implements XSCOM, which is the bridge between MMIO
> >>> and PIB. However it also includes control and status registers and other
> >>> functions that are exposed as PIB (xscom) registers.
> >>>
> >>> To keep things simple, pnv_xscom.c remains the XSCOM bridge
> >>> implementation, and pnv_adu.c implements the ADU registers and other
> >>> functions.
> >>>
> >>> So far, just the ADU no-op registers in the pnv_xscom.c default handler
> >>> are moved over to the adu model.
> >>>
> >>> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
> >>> ---
> >>> include/hw/ppc/pnv_adu.h | 34 ++++++++++++
> >>> include/hw/ppc/pnv_chip.h | 3 +
> >>> include/hw/ppc/pnv_xscom.h | 6 ++
> >>> hw/ppc/pnv.c | 16 ++++++
> >>> hw/ppc/pnv_adu.c | 111 +++++++++++++++++++++++++++++++++++++
> >>> hw/ppc/pnv_xscom.c | 9 ---
> >>> hw/ppc/meson.build | 1 +
> >>> hw/ppc/trace-events | 4 ++
> >>> 8 files changed, 175 insertions(+), 9 deletions(-)
> >>> create mode 100644 include/hw/ppc/pnv_adu.h
> >>> create mode 100644 hw/ppc/pnv_adu.c
> >>>
> >>> diff --git a/include/hw/ppc/pnv_adu.h b/include/hw/ppc/pnv_adu.h
> >>> new file mode 100644
> >>> index 0000000000..9dc91857a9
> >>> --- /dev/null
> >>> +++ b/include/hw/ppc/pnv_adu.h
> >>> @@ -0,0 +1,34 @@
> >>> +/*
> >>> + * QEMU PowerPC PowerNV Emulation of some ADU behaviour
> >>> + *
> >>> + * Copyright (c) 2024, IBM Corporation.
> >>> + *
> >>> + * SPDX-License-Identifier: LGPL-2.1-or-later
> >>
> >>
> >> Did you mean GPL-2.0-or-later ?
> >
> > Hey Cedric,
> >
> > Thanks for reviewing, I've been away so sorry for the late reply.
> >
> > It just came from one of the headers I copied which was LGPL. But
> > there's really nothing much in it and could find a GPL header to
> > copy. Is GPL-2.0-or-later preferred?
>
> I would since all pnv models are GPL.
Some of pnv is actually LGPL. That's okay I'll change to GPL.
> I think some parts of QEMU were initially LGPL (there used to be
> a library, may be that's the reason ?) and other parts are relaxed
> to LGPL because they are reused in libraries.
Thanks,
Nick
next prev parent reply other threads:[~2024-05-03 4:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 11:02 [PATCH 0/2] ppc/pnv: ADU model for POWER9/10 Nicholas Piggin
2024-04-17 11:02 ` [PATCH 1/2] ppc/pnv: Begin a more complete ADU LPC " Nicholas Piggin
2024-04-17 11:25 ` Cédric Le Goater
2024-05-01 12:39 ` Nicholas Piggin
2024-05-02 8:47 ` Cédric Le Goater
2024-05-03 4:51 ` Nicholas Piggin [this message]
2024-05-03 5:44 ` Cédric Le Goater
2024-05-07 4:32 ` Nicholas Piggin
2024-04-17 11:02 ` [PATCH 2/2] ppc/pnv: Implement ADU access to LPC space Nicholas Piggin
2024-04-17 12:25 ` Cédric Le Goater
2024-05-01 12:43 ` Nicholas Piggin
2024-05-02 8:32 ` Cédric Le Goater
2024-05-03 4:47 ` Nicholas Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D0ZQN2YAQ28S.3FGETJPE6XVC8@gmail.com \
--to=npiggin@gmail.com \
--cc=clg@kaod.org \
--cc=fbarrat@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=saif.abrar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).