From: Niek Linnenbank <nieklinnenbank@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Strahinja Jankovic <strahinjapjankovic@gmail.com>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org,
qemu-stable@nongnu.org, Beniamino Galvani <b.galvani@gmail.com>
Subject: Re: [PATCH] tests/avocado: update sunxi kernel from armbian to 6.6.16
Date: Fri, 3 May 2024 21:57:36 +0200 [thread overview]
Message-ID: <CAPan3Wrkm+hJKoxXa_Q6WtQHvsZWOB819UWS-CBeeAzpvb44NQ@mail.gmail.com> (raw)
In-Reply-To: <CAFEAcA8FS=6mn754LGs6KGDahm0vyifiK9P2i57i_TsKvPqUOw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2515 bytes --]
On Tue, Apr 30, 2024 at 4:12 PM Peter Maydell <peter.maydell@linaro.org>
wrote:
> On Mon, 29 Apr 2024 at 21:40, Niek Linnenbank <nieklinnenbank@gmail.com>
> wrote:
> >
> > Hi Peter, Strahinja,
> >
> > I can confirm that the orangepi-pc and cubieboard based tests are
> working OK using the newer kernel 6.6.16:
> >
> > $ ARMBIAN_ARTIFACTS_CACHED=yes AVOCADO_ALLOW_LARGE_STORAGE=yes
> ./build/pyvenv/bin/avocado --show=app,console run -t machine:orangepi-pc -t
> machine:cubieboard tests/avocado/boot_linux_console.py
> > ...
> > RESULTS : PASS 7 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0
> | CANCEL 1
> > JOB TIME : 177.65 s
> >
> > So for this patch:
> > Reviewed-by: Niek Linnenbank <nieklinnenbank@gmail.com>
> > Tested-by: Niek Linnenbank <nieklinnenbank@gmail.com>
>
> Great, thanks. (I'll put this patch into an upcoming arm pullreq.)
>
> > About the BootLinuxConsole.test_arm_orangepi_bionic_20_08 test, I'd be
> happy to provide a patch to revive that test.
> > Since that test is no longer working without having the image available,
> this could also be a good moment to re-consider if armbian is really the
> best input for testing
> > the orangepi-pc board. The image is relatively larger and slower
> compared to other images, like the two openwrt based tests for cubieboard
> and bpim2u.
> >
> > After some searching I've found that Openwrt also has orangepi-pc
> support:
> > https://openwrt.org/toh/xunlong/orange_pi_pc
> >
> > That image works fine with our emulated orangepi-pc board:
> >
> > $ qemu-system-arm -M orangepi-pc -sd
> openwrt-23.05.0-sunxi-cortexa7-xunlong_orangepi-pc-ext4-sdcard.img
> -nographic
>
> > Using openwrt also for the orangepi-pc test instead of armbian also
> gives some consistency between the various tests, to some degree. What are
> you opinions on this?
>
> Yeah, seems reasonable. My main thing to think about would be
> that to understand what extra coverage this gives us that we
> don't already have (there's no point running a ton of tests
> which all amount to "boot a Linux kernel to a shell prompt").
> It looks like what we get from this one is that we are testing
> the "boot off an SD card image via u-boot" flow -- is that right?
>
Yes, correct.
Okey, I'll try to find some time the coming days to prepare a patch that
replaces test_arm_orangepi_bionic_20_08 with a test that uses openwrt
instead.
Niek
>
> thanks
> -- PMM
>
--
Niek Linnenbank
[-- Attachment #2: Type: text/html, Size: 3637 bytes --]
prev parent reply other threads:[~2024-05-03 19:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 15:18 [PATCH] tests/avocado: update sunxi kernel from armbian to 6.6.16 Peter Maydell
2024-04-25 19:31 ` Peter Maydell
2024-04-25 22:24 ` Strahinja Jankovic
2024-04-29 20:40 ` Niek Linnenbank
2024-04-30 14:12 ` Peter Maydell
2024-05-03 19:57 ` Niek Linnenbank [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPan3Wrkm+hJKoxXa_Q6WtQHvsZWOB819UWS-CBeeAzpvb44NQ@mail.gmail.com \
--to=nieklinnenbank@gmail.com \
--cc=b.galvani@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=strahinjapjankovic@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).